Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport of Prefer API over direct config access #34504

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

sharidas
Copy link
Contributor

Description

This idea behind this change set is to use encryption manager API instead of config API.

Related Issue

  • Fixes <issue_link>

Motivation and Context

This idea behind this change set is to use encryption manager API instead of config API.

How Has This Been Tested?

  • Tested the code flow and verified it works as expected.
  • Updated the unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas sharidas self-assigned this Feb 15, 2019
@sharidas sharidas changed the title Prefer api over direct config writing stable10 [stable10] Backport of Prefer API over direct config access Feb 15, 2019
@sharidas sharidas added this to the development milestone Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34504 into stable10 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34504   +/-   ##
===========================================
  Coverage       63.84%   63.84%           
  Complexity      19101    19101           
===========================================
  Files            1264     1264           
  Lines           75355    75355           
  Branches         1292     1292           
===========================================
  Hits            48110    48110           
  Misses          26865    26865           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.27% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.98% <100%> (ø) 19101 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Command/Encryption/Enable.php 100% <100%> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44289a...fffbc75. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34504 into stable10 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34504   +/-   ##
===========================================
  Coverage       63.84%   63.84%           
  Complexity      19101    19101           
===========================================
  Files            1264     1264           
  Lines           75355    75355           
  Branches         1292     1292           
===========================================
  Hits            48110    48110           
  Misses          26865    26865           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.27% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.98% <100%> (ø) 19101 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Command/Encryption/Enable.php 100% <100%> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44289a...fffbc75. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34504 into stable10 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34504   +/-   ##
===========================================
  Coverage       63.84%   63.84%           
  Complexity      19101    19101           
===========================================
  Files            1264     1264           
  Lines           75355    75355           
  Branches         1292     1292           
===========================================
  Hits            48110    48110           
  Misses          26865    26865           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.27% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.98% <100%> (ø) 19101 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Command/Encryption/Enable.php 100% <100%> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44289a...fffbc75. Read the comment docs.

@sharidas sharidas requested a review from IljaN February 15, 2019 12:02
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit f438825 into stable10 Feb 15, 2019
@PVince81 PVince81 deleted the prefer_api_over_direct_config_writing-stable10 branch February 15, 2019 12:26
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants