Prefer API over direct config access

[butonic]

Direct config access should be avoided if we can use a proper API. Also added a TODO for the missing API to enable encryption.

Found while reviewing #31598

[DeepDiver1975]

as usual - @butonic tests are failing - please fix

[PVince81]

@sharidas please take over

[codecov]

Codecov Report

Merging #31607 into master will decrease coverage by 17.41%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #31607       +/-   ##
=============================================
- Coverage     65.11%   47.69%   -17.42%     
=============================================
  Files          1199      109     -1090     
  Lines         69629    10361    -59268     
  Branches       1283     1260       -23     
=============================================
- Hits          45336     4942    -40394     
+ Misses        23919     5050    -18869     
+ Partials        374      369        -5

Flag	Coverage Δ	Complexity Δ
#javascript	52.39% <ø> (-0.71%)	0 <ø> (ø)
#phpunit	37.31% <ø> (-29.19%)	0 <ø> (-18338)

Impacted Files	Coverage Δ	Complexity Δ
apps/files_external/lib/Command/Config.php	0% <0%> (-80%)	0% <0%> (ø)
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
core/js/files/fileinfo.js	85% <0%> (-5%)	0% <0%> (ø)
core/js/sharedialogexpirationview.js	72.05% <0%> (-4.51%)	0% <0%> (ø)
apps/files_external/lib/Command/ListCommand.php	67.72% <0%> (-3.79%)	0% <0%> (ø)
apps/files_sharing/js/app.js	70.62% <0%> (-2.75%)	0% <0%> (ø)
apps/files_external/js/settings.js	49.29% <0%> (-2.55%)	0% <0%> (ø)
core/js/sharedialogview.js	76.41% <0%> (-2.38%)	0% <0%> (ø)
core/js/sharedialogmailview.js	60.39% <0%> (-1.99%)	0% <0%> (ø)
core/js/files/client.js	80.99% <0%> (-1.86%)	0% <0%> (ø)
... and 1108 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bfdea...aeea45d. Read the comment docs.

[codecov]

Codecov Report

Merging #31607 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #31607      +/-   ##
============================================
+ Coverage     65.11%   65.11%   +<.01%     
  Complexity    18338    18338              
============================================
  Files          1199     1199              
  Lines         69629    69630       +1     
  Branches       1283     1283              
============================================
+ Hits          45336    45337       +1     
  Misses        23919    23919              
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	53.1% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.5% <100%> (ø)	18338 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/Command/Encryption/Enable.php	100% <100%> (ø)	7 <0> (ø)	⬇️
...eratedfilesharing/lib/Controller/OcmController.php	66.26% <0%> (+0.2%)	30% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bfdea...64cb9d3. Read the comment docs.

[sharidas]

Updated the PR with the unit test.
Regarding TODO mentioned at https://github.com/owncloud/core/pull/31607/files#diff-8723f509ea809a9e16fb75a2945bf960R59, apart from the encryption command(s), I found only one place in core https://github.com/owncloud/core/blob/master/settings/js/admin.js#L29

[sharidas]

Apart from the minor comment regarding TODO, LGTM 👍

[PVince81]

@sharidas please backport

[sharidas]

Backport PR : #34504

[sharidas]

Need to merge #34505.
Reason for this change : #34505 (comment). I missed the dead code part in the editor. No backport required for #34505. Because it is already covered in the backport PR #34504