[stable7] Close cursor early in calculateFolderSize #13832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method triggers additional queries in $this->update() so to avoid potential database locks or delays, we close the cursor as soon as it is not needed any more
|
let's postpone this - THX |
|
The inspection completed: 8 new issues |
|
Huh what ?! It was supposed to fail on Oracle ? |
|
@PVince81 Oracle is just run on master and the stable branches - not on PRs ;) |
This was referenced Feb 5, 2015
DeepDiver1975
modified the milestones:
7.0.5-current-maintenance,
7.0.6-next-maintenance
|
Refer to this link for build results (access rights to CI server needed): |
|
@PVince81 Seems to work on Oracle: :) |
DeepDiver1975
modified the milestones:
7.0.6-current-maintenance,
7.0.7-next-maintenance
|
Upgrading to 8.0.x is advised. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method triggers additional queries in $this->update() so to avoid
potential database locks or delays, we close the cursor as soon as it is not needed any more
This is the backport that will fail with Oracle (which we reverted here #13803)