Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Close cursor early in calculateFolderSize" for now #13803

Merged
merged 1 commit into from
Jan 30, 2015
Merged

Revert "Close cursor early in calculateFolderSize" for now #13803

merged 1 commit into from
Jan 30, 2015

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen added this to the 8.0-current milestone Jan 30, 2015
@scrutinizer-notifier
Copy link

The inspection completed: 5 new issues

@PVince81
Copy link
Contributor

Should we rather add an exception for Oracle here ? Or close the cursor only for SQLite ?
If we revert this parallel upload will not work on OC 7.

@MorrisJobke
Copy link
Contributor

Can somebody with oracle please retest stable7 because #13798 is now merged and maybe has the fix in doctrine.

@nickvergessen
Copy link
Contributor Author

@MorrisJobke wtf, the linked PR does not touch doctrine in anyway!

@nickvergessen
Copy link
Contributor Author

Should we rather add an exception for Oracle here ? Or close the cursor only for SQLite ?
If we revert this parallel upload will not work on OC 7.

thought the same, but was not sure which one is better. But at least unbreaking it is better atm. We can still refix this later.
Also the second PR you made yesterday was not backported, so this needs to be reinvestigated anyway

@MorrisJobke
Copy link
Contributor

-.- sorry ... mixed up doctrine with sabre dav ... forget everything I said ...

@MorrisJobke
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Jan 30, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/8409/
🚀 Test PASSed. 🚀

@PVince81
Copy link
Contributor

Ok then, let's resubmit with an Oracle-compatible fix. 👍

@nickvergessen
Copy link
Contributor Author

@DeepDiver1975 please run oracle and verify :)

@DeepDiver1975
Copy link
Member

@DeepDiver1975 please run oracle and verify :)

on it ....

@DeepDiver1975
Copy link
Member

👍

DeepDiver1975 added a commit that referenced this pull request Jan 30, 2015
@DeepDiver1975
Merge pull request #13803 from owncloud/revert-close-cursor-stable7
361b70e 
Revert "Close cursor early in calculateFolderSize" for now
@DeepDiver1975 DeepDiver1975 merged commit 361b70e into stable7 Jan 30, 2015
@DeepDiver1975 DeepDiver1975 deleted the revert-close-cursor-stable7 branch January 30, 2015 22:23
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jan 30, 2015
Closed
@PVince81
Copy link
Contributor

@guruz FYI

@PVince81 PVince81 mentioned this pull request Feb 2, 2015
Closed
1 task
@nickvergessen nickvergessen mentioned this pull request Feb 18, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @scrutinizer-notifier @PVince81 @MorrisJobke @DeepDiver1975