Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to copy the public link from the share dialogue on iOS #22336

Closed
oparoz opened this issue Feb 11, 2016 · 33 comments
Closed

It's impossible to copy the public link from the share dialogue on iOS #22336

oparoz opened this issue Feb 11, 2016 · 33 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 11, 2016

For this test to work, you need a generated link which is longer than the field. I've tested on an iPad, on iOS9

  1. Share a folder
  2. Tap on Share link
  3. Try to copy the generated link

I've tried on both Safari and Chrome and was never able to copy the link. The handle on the right never manages to go to the end of the URL. There is no Select all.
It's probably a problem with the platform, but I'm sure a tap could be detected and the entire URL selected for the user, ready to be copied.

@jancborchardt @Henni @raghunayyar @tomneedham @PVince81 @MorrisJobke

@MorrisJobke
Copy link
Contributor

cc @LukasReschke

@PVince81 PVince81 added this to the 9.0-current milestone Feb 12, 2016
@PVince81
Copy link
Contributor

Yeah, I think auto-select the whole field should be implemented.
Maybe this got lost when porting the dialog.

@rullzer @blizzz

@PVince81
Copy link
Contributor

Hint: check how it's done for the webdav URL in the files setting at the bottom of the navigation bar

@rullzer rullzer self-assigned this Feb 12, 2016
@rullzer
Copy link
Contributor

rullzer commented Feb 12, 2016

I'll look into this

@oparoz
Copy link
Contributor Author

oparoz commented Feb 12, 2016

Yeah, I think auto-select the whole field should be implemented.
Maybe this got lost when porting the dialog.

It's working on the desktop, just not on that OS. It's as if there is a conflict between the natural action and the one implemented in the dialogue.

@oparoz
Copy link
Contributor Author

oparoz commented Feb 12, 2016

BTW, this has been broken for a while. Just tested 8.1 and it's the same deal.

@rullzer rullzer removed their assignment Feb 13, 2016
@rullzer
Copy link
Contributor

rullzer commented Feb 13, 2016

Then I'm out of ideas. Somebody with an mobile IOS device please take over. Since this is alsmost impossible for me to fix without testing device.

@oparoz
Copy link
Contributor Author

oparoz commented Feb 13, 2016

As mentioned in the PR, using textarea instead of input solves the problem, but it would be good for some iOS experts to voice in their opinion.

@PVince81
Copy link
Contributor

Switching to textarea might be risky, some things like placeholder might not work properly any more (IE9 and co...) so need to be careful.

@rullzer
Copy link
Contributor

rullzer commented Feb 15, 2016

Also using a textarea is just asking for trouble. They have very different use cases. So other visual stuff might break as well since textareas can do line wrapping etc.

I can't belive we are the only ones that have this issue with IOS so there must be some solution to make it work properly.

@PVince81
Copy link
Contributor

Maybe there is some magic touch-specific CSS stuff to tell it to behave differently ?

@oparoz
Copy link
Contributor Author

oparoz commented Feb 15, 2016

So other visual stuff might break as well since textareas can do line wrapping

You can limit it to 1 row and x columns.

<textarea id="share" rows="1" cols="x"></textarea>

but there might be a styling problem (not in my tests).

@jancborchardt
Copy link
Member

I thought we solved this for the Calendar CalDAV link some time ago. @georgehrke @raghunayyar @Henni do you remember how?

@jancborchardt
Copy link
Member

@oparoz can you test with your iOS devices if copying links works in other places?

  • the link on the bottom of a single-file sharing page
  • the CalDAV links in the Calendar app, bottom left settings area
  • the CardDAV links in the Contacts app, bottom left settings area as well

@georgehrke
Copy link
Contributor

I thought we solved this for the Calendar CalDAV link some time ago.

No, I just checked and it's not working there either 😕

@ghost
Copy link

ghost commented Feb 29, 2016

@Henni can this be resolved by tomorrow? Otherwise it will have to go to 9.1

@rperezb
Copy link

rperezb commented Apr 11, 2016

checked, ownCloud Enterprise Edition 9.1.0 pre alpha (daily) Build:2016-04-11T03:04:42+00:00 f9683aa it does not work on the share link dialog
Sometimes, the copy menu is shown after long press, however, the options shown are: Copy, Define and Share , I missed the select all one, otherwise it's impossible to select the whole link

@PVince81 to your question, the menu to rename a file/folder name works

@ghost ghost modified the milestones: 9.0.3-next-maintenance, 9.0.2-current-maintenance Apr 19, 2016
@PVince81 PVince81 modified the milestones: 9.0.4-next-maintenance, 9.0.3-current-maintenance Jun 17, 2016
@PVince81 PVince81 modified the milestones: 9.0.5, 9.0.4 Jul 18, 2016
@PVince81 PVince81 modified the milestones: 9.0.6, 9.0.5 Sep 21, 2016
@PVince81 PVince81 modified the milestones: 9.0.7, 9.0.6 Oct 20, 2016
@PVince81
Copy link
Contributor

@felixheidecke can you help with this ?

@PVince81 PVince81 assigned felixheidecke and unassigned rperezb Nov 30, 2016
@PVince81 PVince81 modified the milestones: 9.0.8, 9.0.7 Nov 30, 2016
@DeepDiver1975
Copy link
Member

with 9.2 we have the copy to clipboard functionality - this should work on ios as well

@nasli can you help testing this quickly? THX

@nasli
Copy link

nasli commented Nov 30, 2016

@DeepDiver1975 I can not test it, appears empty, some notes added here https://central.owncloud.org/t/contacts-1-5-0-is-about-to-arrive/4259

@nasli
Copy link

nasli commented Nov 30, 2016

Edited:
Fixed #22336 (comment), it was a misconfiguring server setting,

New copy button in contact link works with iphone 6 @DeepDiver1975 👍

@DeepDiver1975
Copy link
Member

@PVince81 case closed?

@nasli
Copy link

nasli commented Dec 1, 2016

Sorry @DeepDiver1975, I misunderstanding this issue, I thought it was the same as the contact one. :(

The share link text field is the same as with the contact, we should add there a copy button too.

Checking this things I noticed some more issues. The UI may contain improvements for touch devices. Tomorrow I will open some.

@PVince81
Copy link
Contributor

PVince81 commented Dec 1, 2016

@nasli do you mean the copy share link in the files app still does not work on master ?

@nasli
Copy link

nasli commented Dec 1, 2016

Yes @PVince81, tested over {"installed":true,"maintenance":false,"version":"9.1.3.0","versionstring":"9.1.3 RC1","edition":""}

@DeepDiver1975
Copy link
Member

Yes @PVince81, tested over {"installed":true,"maintenance":false,"version":"9.1.3.0","versionstring":"9.1.3 RC1","edition":""}

9.1.3 != master

The copy clipboard button is only available on master - see #25418

@nasli
Copy link

nasli commented Dec 2, 2016

Ok, with {"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"9.2.0.3","versionstring":"9.2.0 pre alpha","edition":"Enterprise","productname":"ownCloud"}
there is a new copy button and works. We can close this :)

@PVince81 PVince81 closed this as completed Dec 2, 2016
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.