-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's impossible to copy the public link from the share dialogue on iOS #22336
Comments
Hint: check how it's done for the webdav URL in the files setting at the bottom of the navigation bar |
I'll look into this |
It's working on the desktop, just not on that OS. It's as if there is a conflict between the natural action and the one implemented in the dialogue. |
BTW, this has been broken for a while. Just tested 8.1 and it's the same deal. |
Then I'm out of ideas. Somebody with an mobile IOS device please take over. Since this is alsmost impossible for me to fix without testing device. |
As mentioned in the PR, using textarea instead of input solves the problem, but it would be good for some iOS experts to voice in their opinion. |
Switching to textarea might be risky, some things like placeholder might not work properly any more (IE9 and co...) so need to be careful. |
Also using a textarea is just asking for trouble. They have very different use cases. So other visual stuff might break as well since textareas can do line wrapping etc. I can't belive we are the only ones that have this issue with IOS so there must be some solution to make it work properly. |
Maybe there is some magic touch-specific CSS stuff to tell it to behave differently ? |
You can limit it to 1 row and x columns.
but there might be a styling problem (not in my tests). |
I thought we solved this for the Calendar CalDAV link some time ago. @georgehrke @raghunayyar @Henni do you remember how? |
@oparoz can you test with your iOS devices if copying links works in other places?
|
No, I just checked and it's not working there either 😕 |
@Henni can this be resolved by tomorrow? Otherwise it will have to go to 9.1 |
checked, ownCloud Enterprise Edition 9.1.0 pre alpha (daily) Build:2016-04-11T03:04:42+00:00 f9683aa it does not work on the share link dialog @PVince81 to your question, the menu to rename a file/folder name works |
@felixheidecke can you help with this ? |
with 9.2 we have the copy to clipboard functionality - this should work on ios as well @nasli can you help testing this quickly? THX |
@DeepDiver1975 I can not test it, appears empty, some notes added here https://central.owncloud.org/t/contacts-1-5-0-is-about-to-arrive/4259 |
Edited: New copy button in contact link works with iphone 6 @DeepDiver1975 👍 |
@PVince81 case closed? |
Sorry @DeepDiver1975, I misunderstanding this issue, I thought it was the same as the contact one. :( The share link text field is the same as with the contact, we should add there a copy button too. Checking this things I noticed some more issues. The UI may contain improvements for touch devices. Tomorrow I will open some. |
@nasli do you mean the copy share link in the files app still does not work on master ? |
Yes @PVince81, tested over {"installed":true,"maintenance":false,"version":"9.1.3.0","versionstring":"9.1.3 RC1","edition":""} |
Ok, with {"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"9.2.0.3","versionstring":"9.2.0 pre alpha","edition":"Enterprise","productname":"ownCloud"} |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
For this test to work, you need a generated link which is longer than the field. I've tested on an iPad, on iOS9
I've tried on both Safari and Chrome and was never able to copy the link. The handle on the right never manages to go to the end of the URL. There is no Select all.
It's probably a problem with the platform, but I'm sure a tap could be detected and the entire URL selected for the user, ready to be copied.
@jancborchardt @Henni @raghunayyar @tomneedham @PVince81 @MorrisJobke
The text was updated successfully, but these errors were encountered: