Touching a link share url should select the whole field #22344
Conversation
| @@ -81,6 +81,7 @@ | |||
| 'keyup input.linkPassText': 'onPasswordKeyUp', | |||
| 'click .linkCheckbox': 'onLinkCheckBoxChange', | |||
| 'click .linkText': 'onLinkTextClick', | |||
| 'touchstart .linkText': 'onLinkTextClick', | |||
There was a problem hiding this comment.
ah! so we already had the click but it wanted a touch event... nice one
There was a problem hiding this comment.
Well I think that is it. Since it is the difference between the webdav link and the linkshare link. But chrome on android is happy with both.
The way I tested it is by disabling the click on the linkText and then it still worked :P
So lets see if IOS is happy as well :P
|
Unfortunately, it still doesn't work on iOS :(. When tapping, the cursor jumps to the end of the field, but it's still impossible to select the whole URL. |
|
@oparoz can you try again? |
|
OK, so now, the whole link gets selected, but it's impossible to get the menu to copy that selection. |
|
@oparoz I guess you probably have the same problem with the Webdav URL then, the one in the navigation bar of the files app, at the bottom (cog icon) ? |
|
@PVince81 - Indeed. Tapping on it brings the handles, which flash and disappear and trying to select the URL is impossible. |
|
mmm then I'm out of idea's... especially since I can't test locally ;) |
|
@owncloud/ios-developers maybe one of you has an idea? |
|
Using textarea instead of input worked for me... |
|
@LukasReschke @georgehrke @raghunayyar iOS users test this please :) |
|
I'm closing this as I have no way to verify... somebody with a mobile IOS device feel free to reopen and take over... |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #22336
We did not have a touchstart event anymore. Added back now.
Tested on Android and that event is emitted.
@oparoz please verify it works on IOS as well.