[9.2] Add clipboard button to public share link #25418

DeepDiver1975 · 2016-07-08T12:31:34Z

and I also moved the mail send button:

mention-bot · 2016-07-08T12:31:35Z

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @jancborchardt and @MorrisJobke to be potential reviewers

SergioBertolinSG · 2016-07-08T12:53:01Z

Icon appears before sharing by link. It copies to clipboard "use-clipboard-api".

SergioBertolinSG · 2016-07-08T13:03:24Z

In safari, the copied string is the path of the file, not the public shared link.

Something like host/index.php/apps/files/?dir=/COSAS/SUBCOSAS&fileid=10
Instead of host/index.php/s/0wmlnsYFkKh5fpT

DeepDiver1975 · 2016-07-08T13:19:48Z

Icon appears before sharing by link. It copies to clipboard "use-clipboard-api"

fixed

DeepDiver1975 · 2016-07-08T13:22:04Z

In safari, the copied string is the path of the file, not the public shared link.

Something like host/index.php/apps/files/?dir=/COSAS/SUBCOSAS&fileid=10
Instead of host/index.php/s/0wmlnsYFkKh5fpT

strange 💩

jancborchardt · 2016-07-08T15:25:56Z

Ideally the link should directly be copied to the clipboard as soon as you click »Share link«. That will make the flow even more seamless. Can you change it so that happens automatically?

jvillafanez · 2016-07-11T07:39:54Z

@jancborchardt I haven't seen that behaviour in any other app. It seems unnatural that clicking in the checkbox copies the text. What if the user unchecks it later? What would happen with the clipboard?

In addition, users won't know that the link is copied unless they're told explicitly. If we don't use any kind of notification, this feature won't be used properly. So, where and how will the notification be placed in this case?

Moreover, the previous clipboard contents will be overwritten. I'd rather have an explicit user interaction. We don't know what will the user do with the link, and we shouldn't suppose that he will want to copy the link.

DeepDiver1975 · 2016-07-11T08:02:37Z

@jancborchardt I haven't seen that behaviour in any other app. It seems unnatural that clicking in the checkbox copies the text. What if the user unchecks it later? What would happen with the clipboard?

In addition, users won't know that the link is copied unless they're told explicitly. If we don't use any kind of notification, this feature won't be used properly. So, where and how will the notification be placed in this case?

Moreover, the previous clipboard contents will be overwritten. I'd rather have an explicit user interaction. We don't know what will the user do with the link, and we shouldn't suppose that he will want to copy the link.

Notifications can be implemented using the tooltip - this should not be an issue.

But I agree on the matter that the clipboard is overwritten which is somewhat unexpected and make the user angry if some valuable content is in there.

MorrisJobke · 2016-07-11T08:04:37Z

we shouldn't suppose that he will want to copy the link.

But creating a link without copying it is kind of senseless, isn't it? I never created a link share (beside testing of the sharing app) and didn't copied it.

MorrisJobke · 2016-07-11T08:07:17Z

But creating a link without copying it is kind of senseless, isn't it? I never created a link share (beside testing of the sharing app) and didn't copied it.

I just have no thing in mind: sending it via email: but then there should be definitely something like a "guide":

you created a share: What to do with this share? Send via email - copy link - ...

DeepDiver1975 · 2016-07-11T08:13:08Z

I just have no thing in mind: sending it via email: but then there should be definitely something like a "guide":

you created a share: What to do with this share? Send via email - copy link - ...

There are for sure things which can be improved - let's for now just introduce the copy link button.
There is nothing really playing against this - right?

jancborchardt · 2016-07-11T08:35:48Z

Yeah, let’s go step-by-step. I still think automatically copying it makes the flow even easier and reduces a step you are surely gonna take, which is copying the link.

The clipboard button we need in any case for when you want to get an existing shared link quickly, so 👍

DeepDiver1975 · 2016-07-15T11:58:26Z

@SergioBertolinSG safari has been fixed as far as technically possible.

This is the way this works once the user with safari hits the button:

the text in the input field is selected
a tool tip will popup telling the user to press cmd+C to copy

In addition on ipad and ihone the tooltiop will tell the user that it is not supported - maybe better in this case would be to simply not show the button - but this is a future improvment from my pov

SergioBertolinSG · 2016-07-15T13:41:35Z

Works fine 👍

Tested on chrome, safari (with that workaround) and edge.

PVince81 · 2016-07-15T13:47:23Z

core/js/sharedialoglinkshareview.js

+			clipboard.on('error', function (e) {
+				$input = $(e.trigger);
+				var actionMsg = '';
+				if (/iPhone|iPad/i.test(navigator.userAgent)) {


if we ever want to reuse that button elsewhere, would be good to have all this logic in a central place, like js.js in OC.Util or so

We can do this once necessary - I have no clue what the perf impact is if we setup the clipboard instance in js.js

Agreed. Note that the way I see it is more like a method OC.Util.setupClipboard($inputField) that does this lazily.

Anyway, let's merge this for now.

Anyway, let's merge this for now.

THX 🎉

ghost · 2016-09-20T05:23:31Z

Great, guys! For my Passwords app I really would like to have it in a global function.
For now, I'll delete my own dependency and copy your code. Thanks again!

DeepDiver1975 · 2016-09-20T05:56:12Z

@FCTURNER please have a look at #25757 - it ships the global function - let me know if this works out for you - THX

ghost · 2016-09-20T11:11:04Z

That's awesome! I'll let you know, thanks!

lock · 2019-08-04T18:02:18Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

DeepDiver1975 added the 3 - To Review label Jul 8, 2016

DeepDiver1975 added this to the 9.2 milestone Jul 8, 2016

DeepDiver1975 force-pushed the use-clipboard-api branch from 09814c6 to c014092 Compare July 8, 2016 12:44

DeepDiver1975 force-pushed the use-clipboard-api branch from c014092 to b3e202d Compare July 8, 2016 13:19

tcitworld mentioned this pull request Jul 8, 2016

Add clipboard button to caldav link owncloud/calendar#609

Closed

DeepDiver1975 mentioned this pull request Jul 8, 2016

Add clipboard button to caldav link owncloud/calendar#414

Open

MariusBluem mentioned this pull request Jul 8, 2016

Copy Links at a mobile device nextcloud/server#346

Closed

icewind1991 mentioned this pull request Jul 8, 2016

»Share via link« should automatically copy the link to the clipboard nextcloud/server#276

Closed

DeepDiver1975 force-pushed the use-clipboard-api branch from a5d64bd to 43e2af3 Compare July 11, 2016 08:14

DeepDiver1975 force-pushed the use-clipboard-api branch from 43e2af3 to 54a3ce1 Compare July 11, 2016 09:14

DeepDiver1975 added 2 commits July 15, 2016 13:53

Add clipboard button to public share link

72fe60e

Use an icon to set the email instead of a button with string

cc67547

DeepDiver1975 force-pushed the use-clipboard-api branch from 54a3ce1 to cc67547 Compare July 15, 2016 11:53

PVince81 reviewed Jul 15, 2016
View reviewed changes

PVince81 merged commit d4c0838 into master Jul 15, 2016

PVince81 deleted the use-clipboard-api branch July 15, 2016 14:15

LukasReschke mentioned this pull request Jul 20, 2016

Use clipboard api nextcloud/server#467

Merged

DeepDiver1975 mentioned this pull request Dec 1, 2016

It's impossible to copy the public link from the share dialogue on iOS #22336

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.2] Add clipboard button to public share link #25418

[9.2] Add clipboard button to public share link #25418

DeepDiver1975 commented Jul 8, 2016 •

edited

Loading

mention-bot commented Jul 8, 2016

SergioBertolinSG commented Jul 8, 2016 •

edited

Loading

SergioBertolinSG commented Jul 8, 2016

DeepDiver1975 commented Jul 8, 2016

DeepDiver1975 commented Jul 8, 2016

jancborchardt commented Jul 8, 2016

jvillafanez commented Jul 11, 2016

DeepDiver1975 commented Jul 11, 2016

MorrisJobke commented Jul 11, 2016

MorrisJobke commented Jul 11, 2016

DeepDiver1975 commented Jul 11, 2016

jancborchardt commented Jul 11, 2016

DeepDiver1975 commented Jul 15, 2016

SergioBertolinSG commented Jul 15, 2016

PVince81 Jul 15, 2016

DeepDiver1975 Jul 15, 2016

PVince81 Jul 15, 2016

DeepDiver1975 Jul 15, 2016

ghost commented Sep 20, 2016

DeepDiver1975 commented Sep 20, 2016

ghost commented Sep 20, 2016

lock bot commented Aug 4, 2019

[9.2] Add clipboard button to public share link #25418

[9.2] Add clipboard button to public share link #25418

Conversation

DeepDiver1975 commented Jul 8, 2016 • edited Loading

mention-bot commented Jul 8, 2016

SergioBertolinSG commented Jul 8, 2016 • edited Loading

SergioBertolinSG commented Jul 8, 2016

DeepDiver1975 commented Jul 8, 2016

DeepDiver1975 commented Jul 8, 2016

jancborchardt commented Jul 8, 2016

jvillafanez commented Jul 11, 2016

DeepDiver1975 commented Jul 11, 2016

MorrisJobke commented Jul 11, 2016

MorrisJobke commented Jul 11, 2016

DeepDiver1975 commented Jul 11, 2016

jancborchardt commented Jul 11, 2016

DeepDiver1975 commented Jul 15, 2016

SergioBertolinSG commented Jul 15, 2016

PVince81 Jul 15, 2016

Choose a reason for hiding this comment

DeepDiver1975 Jul 15, 2016

Choose a reason for hiding this comment

PVince81 Jul 15, 2016

Choose a reason for hiding this comment

DeepDiver1975 Jul 15, 2016

Choose a reason for hiding this comment

ghost commented Sep 20, 2016

DeepDiver1975 commented Sep 20, 2016

ghost commented Sep 20, 2016

lock bot commented Aug 4, 2019

DeepDiver1975 commented Jul 8, 2016 •

edited

Loading

SergioBertolinSG commented Jul 8, 2016 •

edited

Loading