Smashbox tests running against master+encryption

[nickvergessen]

Without Encryption

• test_scrapeLogFile.py ✅
• test_reshareDir.py ✅
• test_uploadFiles.py ✅
• test_shareDir.py: ✅ Fix failing shareDir test that assumed the dir would not exist smashbox#72
• test_shareFile.py: ✅ reported at WebDAV PUT on file share fails with 500 #15786, PR at use cross storage move when renaming the part file during webdav put #16159
• test_shareGroup.py: ✅ Fix the user and group names in shareGroup.py smashbox#73
• test_sharePermissions.py: ✅ Correctly sync (as owner and recipient) and fix the share call smashbox#74

With Encryption

• test_scrapeLogFile.py ✅
• test_reshareDir.py: Login new users to generate their encryption keys smashbox#70
• test_uploadFiles.py: Login new users to generate their encryption keys smashbox#70
• test_shareDir.py:
  • Fix failing shareDir test that assumed the dir would not exist smashbox#72
  • Login new users to generate their encryption keys smashbox#70
• test_shareFile.py: reported at WebDAV PUT on file share fails with 500 #15786
  • use cross storage move when renaming the part file during webdav put #16159
  • Login new users to generate their encryption keys smashbox#70
• test_shareGroup.py: Fix the user and group names in shareGroup.py smashbox#73
• test_sharePermissions.py:
  • Correctly sync (as owner and recipient) and fix the share call smashbox#74
  • known to be broken "Create" share permission doesn't let you upload when encryption is enabled #12966

[oparoz]

Those share bugs could come from the read-only cache bug fixed in #15721

[DeepDiver1975]

#15721

was just merged - @nickvergessen please rebase and fire up the tests again please.

@oparoz THX for the hint - let's see ...

[nickvergessen]

Nop, still failing, but it might be a problem on my (old) mashine, because they seem to fail on master without encryption aswell

[oparoz]

:(

[nickvergessen]

The tests fail, because the mount point for the shared file ends with a trailing slash.
Summoning @PVince81

[PVince81]

Could be a regression due to this addition by myself: #15570
It would add a trailing slash to file shares too... but now removing the fix wouldn't work too because some places in the code call setMountPoint() with a missing trailing slash. Maybe the fix is to fix the caller instead (which isn't ideal) but also need to take care of the file share cases...

[PVince81]

Hmmm no, this is not caused by the PR I mentioned. I ran test_shareDir.py and test_shareFile.py in much older versions in git, and I saw that:

• test_shareDir.py already failed before that version (without -a)
• test_shareFile.py works (without -a)

@jnfrmarks did test_shareDir.py ever pass before ?

@nickvergessen when running the tests don't forget to add -a to make sure it runs all test cases. It seems that there are more fails with it... (maybe they aren't finished)

I'll bisect the potential regression.

[PVince81]

The fail for the test_shareFile.py appears since 6a59502 (#12006) from @icewind1991
Maybe we failed to update the etag of shared files or some hooks do not get fired.

[PVince81]

I have raised this separately as I was able to reproduce something: #15786

[jnfrmarks]

I thought I fixed shareDir - it's a test issue - "shareeTwo" was creating the directory and sync'ing the same directory - causing two directories to be created locally.

[nickvergessen]

@PVince81 yes it works reliable on stable8.
The line in the code that I found out is returning wrong stuff (empty string for a given path) is https://github.com/owncloud/core/pull/12006/files#diff-2e4a54e72d495abc750a9bc445da15a0R115
So that is why it is failing since then.

[MorrisJobke]

@nickvergessen Can you retest shareFile.py? #15786 #15787 was merged.

[nickvergessen]

Still fails with

2015-04-23 10:54:07,312 - ERROR - sharer -
md5 of modified file /home/nickv/ownCloud/Smashbox/tmpdir/test_shareFile/sharer/TEST_FILE_MODIFIED_USER_SHARE.dat did not change: expected 45b565af28a2998fa8d5dae7eb6e660e, got 45b565af28a2998fa8d5dae7eb6e660e
"md5 of modified file %s did not change: expected %s, got %s" % (fn, md5, actual_md5)) failed in expect_modified() ["/home/nickv/ownCloud/Smashbox/smashbox/python/smashbox/utilities/__init__.py" at line 670]

[DeepDiver1975]

@jnfrmarks @nickvergessen @PVince81 can you please digg into this and find out what's going wrong here? THX

[PVince81]

@nickvergessen does this test fail without encryption too ? Is it specific ? It could also be etag propagation issue.

[PVince81]

Let's make it clearer, regression-wise for test_shareFile.py:

• master without encryption: fails with Smashbox tests running against master+encryption #15781 (comment)
• master with encryption: fails with Smashbox tests running against master+encryption #15781 (comment)
• stable8 without encryption: success
• stable8 with encryption: success

So this failing is not related to encryption.
But there's another regression somewhere, I'll bisect this.

[DeepDiver1975]

But there's another regression somewhere, I'll bisect this.

thx

[PVince81]

Wait, it's still 6a59502
The merged PR was not for the fix (#15781 (comment) was a misunderstanding).
The issue is still #15786

[PVince81]

WebDAV PUT fails when putting a shared file, so obviously the file didn't change and smashbox says the md5 didn't change either.

[nickvergessen]

Without Encryption

Test	Status
test_scrapeLogFile.py	✅
	-
test_reshareDir.py	✅
	-
test_shareDir.py	❌ ERROR - shareeTwo - File .../tmpdir/test_shareDir/shareeTwo/localShareDir exists but should not error_check(not os.path.exists(fn), "File %s exists but should not" % fn) failed in expect_does_not_exist() [.../smashbox/python/smashbox/utilities/__init__.py at line 690]
	worked before
test_shareFile.py	❌ ERROR - sharer - md5 of modified file .../tmpdir/test_shareFile/sharer/TEST_FILE_MODIFIED_USER_SHARE.dat did not change: expected 45b565af28a2998fa8d5dae7eb6e660e, got 45b565af28a2998fa8d5dae7eb6e660e "md5 of modified file %s did not change: expected %s, got %s" % (fn, md5, actual_md5)) failed in expect_modified() [.../smashbox/python/smashbox/utilities/__init__.py at line 670]
	worked before, reported at #15786, PR at #16159
test_shareGroup.py	❌ ERROR - shareeTwo - File .../tmpdir/test_shareGroup/shareeTwo/TEST_FILE_GROUP_SHARE.dat should exist error_check(os.path.exists(sharedFile), "File %s should exist" %sharedFile) failed in shareeTwo() [.../smashbox/lib/oc-tests/test_shareGroup.py at line 213]
	known to be broken
test_sharePermissions.py	❌ CRITICAL - recipient_worker - Exception occured: HTTP error: 404 -- Traceback (most recent call last): File python/smashbox/multiprocessing_engine.py, line 161, in worker_wrap -- f(step) -- File .../smashbox/lib/oc-tests/test_sharePermissions.py, line 233, in recipient_worker -- error_check(oc.file_info(SHARED_DIR_NAME) is not None, 'Recipient did not receive the shared folder')
	known to be broken
test_uploadFiles.py	✅
	-

With Encryption

Test	Status
test_scrapeLogFile.py	✅
	-
test_reshareDir.py	❌ ERROR - shareeTwo - File .../tmpdir/test_reshareDir/shareeTwo/TEST_FILE_USER_RESHARE.dat should exist error_check(os.path.exists(sharedFile), "File %s should exist" %sharedFile) failed in shareeTwo() [.../smashbox/lib/oc-tests/test_reshareDir.py at line 140]
	works without encryption
test_shareDir.py	❌ ERROR - shareeOne - /home/nickv/ownCloud/Smashbox/tmpdir/test_shareDir/shareeOne/localShareDir/TEST_FILE_MODIFIED_USER_SHARE.dat does not exist -- ERROR - sharer - md5 of modified file .../tmpdir/test_shareDir/sharer/localShareDir/TEST_FILE_MODIFIED_USER_SHARE.dat did not change: expected 45b565af28a2998fa8d5dae7eb6e660e, got 45b565af28a2998fa8d5dae7eb6e660e "md5 of modified file %s did not change: expected %s, got %s" % (fn, md5, actual_md5)) failed in expect_modified() [.../smashbox/python/smashbox/utilities/__init__.py at line 670]
	fails earlier then without encryption
test_shareFile.py	❌ ERROR - shareeOne - File .../tmpdir/test_shareFile/shareeOne/TEST_FILE_USER_SHARE.dat should exist error_check(os.path.exists(sharedFile), "File %s should exist" %sharedFile) failed in shareeOne() [.../smashbox/lib/oc-tests/test_shareFile.py at line 162] -- ERROR - sharer - md5 of modified file .../tmpdir/test_shareFile/sharer/TEST_FILE_MODIFIED_USER_SHARE.dat did not change: expected 45b565af28a2998fa8d5dae7eb6e660e, got 45b565af28a2998fa8d5dae7eb6e660e "md5 of modified file %s did not change: expected %s, got %s" % (fn, md5, actual_md5)) failed in expect_modified() [.../smashbox/python/smashbox/utilities/__init__.py at line 670]
	fails earlier then without encryption
test_shareGroup.py	❌
	known to be broken
test_sharePermissions.py	❌
	known to be broken
test_uploadFiles.py	❌ ERROR - sharer02 - File .../tmpdir/test_uploadFiles/sharer02/localShareDir/TEST_FILE_NEW_USER_SHARE_1.dat should exist error_check(os.path.exists(sharedFile), "File %s should exist" %sharedFile) failed in checkFilesExist() [.../smashbox/lib/oc-tests/test_uploadFiles.py at line 213]
	works without encryption

So the difference is: test_reshareDir and test_uploadFiles fail, while test_shareDir and test_shareFile fail earlier.
Not sure how much will be resolved by the fix for #15786 and we are still waiting for @icewind1991 to have a look at that.

[nickvergessen]

owncloud/smashbox#70 fixes the encryption specific fails of smashbox.
Once we log in the users after creating them, the keys get generated, so sharing etc don't fail anymore.

New encryption result is then:

Test	Status
test_scrapeLogFile.py	✅
test_reshareDir.py	✅
test_shareDir.py	❌ same as without
test_shareFile.py	❌ same as without
	✅ with #16159
test_shareGroup.py	❌ same as without
test_sharePermissions.py	❌ same as without
test_uploadFiles.py	✅

[nickvergessen]

owncloud/smashbox#72 fixes shareDir.py (without and with encryption)
owncloud/smashbox#73 fixes shareGroup.py (without and with encryption)
owncloud/smashbox#74 fixes sharePermissions.py (without encryption)

[nickvergessen]

We are now back to green without encryption

[DeepDiver1975]

so i guess we can close this now - thx @nickvergessen for taking care

[PVince81]

@nickvergessen did you run them always with -a ? Else it will only run the first test suite see cernbox/smashbox#12)

[nickvergessen]

No, I run each test case individually owncloud/smashbox#88 (because I get problems otherwise with the rundir not being empty in the beginning, fixed by owncloud/smashbox#78 )