Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly sync (as owner and recipient) and fix the share call #74

Merged
merged 1 commit into from
May 7, 2015

Conversation

nickvergessen
Copy link

Reasons why the test was wrong

  1. The call to share_file_with_user was incorrect, resulting in a 404 on the share API
  2. The directory of the recipient was not synced after the share was created

Fix #67

@jnfrmarks

@nickvergessen
Copy link
Author

PS: only fixes without encryption. With encryption I still get errors:

2015-05-07 18:20:59,668 - ERROR - recipient_worker - Got status code 500
2015-05-07 18:20:59,695 - ERROR - recipient_worker - Operation "move_in_overwrite" must be allowed when share permissions are 31 'Operation "%s" must be %s when share permissions are %i' % (operation, success_message, perms) failed in recipient_worker() ["/home/nickv/ownCloud/Smashbox/smashbox/lib/oc-tests/test_sharePermissions.py" at line 251]
INFO:urllib3.connectionpool:Resetting dropped connection: 127.0.0.1
2015-05-07 18:21:00,012 - ERROR - recipient_worker - Got status code 500
2015-05-07 18:21:00,013 - ERROR - recipient_worker - Operation "move_in_subdir_overwrite" must be allowed when share permissions are 31 'Operation "%s" must be %s when share permissions are %i' % (operation, success_message, perms) failed in recipient_worker() ["/home/nickv/ownCloud/Smashbox/smashbox/lib/oc-tests/test_sharePermissions.py" at line 251]
INFO:urllib3.connectionpool:Resetting dropped connection: 127.0.0.1
2015-05-07 18:21:00,771 - ERROR - recipient_worker - Got status code 500
2015-05-07 18:21:00,771 - ERROR - recipient_worker - Operation "delete" must be allowed when share permissions are 31 'Operation "%s" must be %s when share permissions are %i' % (operation, success_message, perms) failed in recipient_worker() ["/home/nickv/ownCloud/Smashbox/smashbox/lib/oc-tests/test_sharePermissions.py" at line 251]
INFO:urllib3.connectionpool:Resetting dropped connection: 127.0.0.1
2015-05-07 18:21:02,065 - ERROR - recipient_worker - 3 error(s) reported

@jnfrmarks
Copy link

👍

tested with 1.8.1 client and 8.0.3 server

nickvergessen added a commit that referenced this pull request May 7, 2015
…ePermissions

Correctly sync (as owner and recipient) and fix the share call
@nickvergessen nickvergessen merged commit 2916538 into master May 7, 2015
@nickvergessen nickvergessen deleted the correctly-sync-and-share-in-sharePermissions branch May 7, 2015 19:02
mrow4a pushed a commit that referenced this pull request Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oc-tests/test_sharePermissions.py hangs out
2 participants