Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login new users to generate their encryption keys #70

Merged
merged 1 commit into from
May 13, 2015

Conversation

nickvergessen
Copy link

This makes the following tests pass with encryption:

@jnfrmarks @SergioBertolinSG please review

PS: should go upstream once merged here

@jnfrmarks
Copy link

The login bits seem to work but the test is failing with this in the log file:


{"reqId":"wIQB02xT42yvg+XJaX88","remoteAddr":"172.18.5.197","app":"PHP","message":"fopen(\/var\/www\/html\/owncloud\/data\/user2): failed to open stream: Is a directory at \/var\/www\/html\/owncloud\/apps\/files_locking\/lib\/lock.php#134","level":3,"time":"2015-05-07T19:57:10+00:00"}
{"reqId":"wIQB02xT42yvg+XJaX88","remoteAddr":"172.18.5.197","app":"webdav","message":"Exception: {\"Message\":\"HTTP\\\/1.1 503 Target file  is locked by another process.\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/html\\\/owncloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1087): OC\\\\Connector\\\\Sabre\\\\File->put(Resource id #30)\\n#1 \\\/var\\\/www\\\/html\\\/owncloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(501): Sabre\\\\DAV\\\\Server->updateFile('TEST_FILE_MODIF...', Resource id #30, NULL)\\n#2 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpPut(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#3 \\\/var\\\/www\\\/html\\\/owncloud\\\/3rdparty\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#4 \\\/var\\\/www\\\/html\\\/owncloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(469): Sabre\\\\Event\\\\EventEmitter->emit('method:PUT', Array)\\n#5 \\\/var\\\/www\\\/html\\\/owncloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#6 \\\/var\\\/www\\\/html\\\/owncloud\\\/apps\\\/files\\\/appinfo\\\/remote.php(83): Sabre\\\\DAV\\\\Server->exec()\\n#7 \\\/var\\\/www\\\/html\\\/owncloud\\\/remote.php(84): require_once('\\\/var\\\/www\\\/html\\\/o...')\\n#8 {main}\",\"File\":\"\\\/var\\\/www\\\/html\\\/owncloud\\\/lib\\\/private\\\/connector\\\/sabre\\\/file.php\",\"Line\":174}","level":4,"time":"2015-05-07T19:57:10+00:00"}

Also in core at owncloud/core#16182

@nickvergessen
Copy link
Author

I'm currently testing without files locking.

Only trashbin, versions, sharing, provisioning (and encryption)

Which test is failing for you?

@jnfrmarks
Copy link

I'm not sure: it was one of the three above ;)

Edit: Ah! I wrote the test name in the core issue: test_shareFile.py

@nickvergessen
Copy link
Author

Did you have the core PR merged that is specified ?

@jnfrmarks
Copy link

@nickvergessen

The description refers to the core issue which morphed into a files_locking issue: owncloud-archive/files_locking#24.

@nickvergessen
Copy link
Author

No, files_locking shall be disabled as for now. The issue mentioned is owncloud/core#16159 which was merged. so please retry ;)

nickvergessen added a commit that referenced this pull request May 13, 2015
…yption-keys

Login new users to generate their encryption keys
@nickvergessen nickvergessen merged commit e20c6fd into master May 13, 2015
@nickvergessen nickvergessen deleted the login-new-users-to-generate-encryption-keys branch May 13, 2015 15:36
@nickvergessen
Copy link
Author

Cern PR cernbox#22

ogoffart pushed a commit that referenced this pull request Sep 16, 2016
Initial testplan from Matthieu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants