Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Replace Log_OC with timber #293

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Replace Log_OC with timber #293

merged 4 commits into from
Jan 15, 2020

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep changed the title Replace Log_OC with timber Replace Log_OC with timber [WIP] Dec 20, 2019
@abelgardep abelgardep self-assigned this Jan 9, 2020
@abelgardep abelgardep force-pushed the replace_logOC_with_timber branch 2 times, most recently from 6f1a795 to 945947f Compare January 13, 2020 13:28
@abelgardep
Copy link
Contributor Author

@hannesa2 Thanks for the suggestions. They are already applied 👍

@hannesa2 hannesa2 self-requested a review January 14, 2020 04:50
@davigonz davigonz changed the title Replace Log_OC with timber [WIP] Replace Log_OC with timber Jan 14, 2020
@abelgardep abelgardep force-pushed the replace_logOC_with_timber branch 2 times, most recently from d90c4d2 to 11c4dbe Compare January 14, 2020 07:53
@davigonz davigonz merged commit 285306e into master Jan 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the replace_logOC_with_timber branch January 15, 2020 15:18
@hannesa2
Copy link
Contributor

hannesa2 commented Jan 16, 2020

I would change all Log.x() to Timber.x() as well, eg

Log.d(TAG, "File with name " + mFile.getName() + " and size " + mFile.length() +

same to

@hannesa2
Copy link
Contributor

More then this, I would convert lint LogNotTimber to an error.
Unfortunately printStackTrace() has no lint issue.

What do you think ?

@hannesa2
Copy link
Contributor

Additionally you should build during pull request this repo with
./gradlew clean build !

Otherwise you have found this

@hannesa2
Copy link
Contributor

#297 Fix sample app

@abelgardep
Copy link
Contributor Author

Additionally you should build during pull request this repo with
./gradlew clean build !

Otherwise you have found this

Yes, i think we should include this check in bitrise in order not to have the same problem in the future. Don't you think @davigonz ?

I would change all Log.x() to Timber.x() as well, eg

Log.d(TAG, "File with name " + mFile.getName() + " and size " + mFile.length() +

same to

Sure, thanks for reporting this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants