Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated logs #2757

Closed
abelgardep opened this issue Dec 11, 2019 · 4 comments
Closed

Remove deprecated logs #2757

abelgardep opened this issue Dec 11, 2019 · 4 comments
Assignees
Milestone

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Dec 11, 2019

During #2730, some logs functions were deprecated in order to avoid a big refactor and posible conflicts with new architecture modularization. Now, modularization has been merged so these deprecated functions can be removed and replaced with new ones.

Screenshot 2019-12-11 at 13 33 32

PR

@davigonz davigonz added this to the 2.15 milestone Dec 12, 2019
@hannesa2
Copy link
Contributor

Please switch direct to Timber and delete Log_OC complete, then I can get rid of the need of JakeWharton/timber#371 and can use common upstream version instead of special version which support delegation

@hannesa2
Copy link
Contributor

It's not a hard requirement for this timber-only task, but I start to remove it AppDevNext/Logcat#31

@abelgardep
Copy link
Contributor Author

abelgardep commented Dec 19, 2019

To move this forward as soon as possible, it would be great to know how to approach this.
3 options:

  • Keep using Log_OC but updated methods.
  • Switch direct to Timber not removing Log_OC
  • Switch direct to Timber removing Log_OC.

@davigonz @jesmrec @michaelstingl

@davigonz
Copy link
Contributor

davigonz commented Dec 19, 2019

Log_OC is meant to log the ownCloud App for Android and oC Android library and I think that we should not maintain it just because it could be used by other apps using the library, our library is not a logging library but "an easy way to communicate Android apps with ownCloud servers".

Logging is an additional task that any app using the oC Android library should take care of in my opinion.

Said this, I would implement the last option Switch direct to Timber removing Log_OC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants