Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logging by delegation #371

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

hannesa2
Copy link

@hannesa2 hannesa2 commented Nov 1, 2019

When you have to use Timber with a delegator, currently you log just the delegator class. -sad-
Or when you change logging tool just in one place and do not change every log call in code (this can be very easy > 1000 places), you probably need a delegator.

With this PR you can solve this (in my point of view) elegant

@drewhamilton
Copy link

Solves the same problem as #362. Both target the new Timber API (5.x) which unfortunately hasn't seen any action in a year or so.

@hannesa2 hannesa2 force-pushed the EnableLoggingByDelegation branch 3 times, most recently from c509e48 to 7a942ba Compare July 15, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants