Build sample app successful #297
Conversation
|
This synk runs into an issue You can remove this commit |
davigonz
force-pushed
the
BuildSampleApp
branch
from
161bf34
to
11a2ec1
Compare
| @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.0.1-all.zip | |||
There was a problem hiding this comment.
There's a new Gradle version => 6.1
There was a problem hiding this comment.
I created this PR 5 days ago, there was no 6.1
What prevents me to have a 6.0.1 when this will be reviewed again ?
That's why I vote to approve and merge this, to go ahead.
And for sure I will create a follow up new PR with 6.1
There was a problem hiding this comment.
Well, not really, 6.1 was released one day before this PR was created. https://gradle.org/releases/ , that's why I have suggested this change
There was a problem hiding this comment.
The reality is always faster: there is a 6.1.1
But it's pointless to block this PR because of this
There was a problem hiding this comment.
6.1.1 has been released after this PR creation while 6.1 was released before this PR creation, as I said in my comment above. That's why I suggested to use directly 6.1 instead of 6.0.1. I already applied the change yesterday (here and in owncloud/android#2792) and the PRs are ready to QA since then.
|
@hannesa2 just a couple of changes here |
@davigonz With this message I've bigger doubts, instead of a more recent version Gradle |
@hannesa2 do not worry, we are aware of it @DeepDiver1975 could you remove |
|
No much to test here beyond the basic checks. Approved. |
Now you can do a successful
./gradlew clean buildI did
Log.x()toTimber.x()It will be referenced in the app via owncloud/android#2792