AO3-6638 Intermittent failure in cucumber tag_wrangling, orphan_pseud, and user_delete features #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Tests Only
5 tasks
|
The failure currently happening is the one solved here. |
Unfortunately not. The PR is for the orphan_work.feature file, this failure is in:
But I would still say it's a flaky test and it can likely be fixed in the same way. |
|
Doh! Read too quickly. Thanks for the head up. Might as well add fix for this one too while I'm at it. |
Inspired by otwcode#4656
Bilka2
reviewed
Nov 11, 2023
More consistent with other formerly intermittent tests
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Bilka2
approved these changes
Nov 13, 2023
brianjaustin
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
sarken
changed the title
5 tasks
ceithir
added a commit
to ceithir/otwarchive
that referenced
this pull request
Dec 26, 2023
brianjaustin
pushed a commit
that referenced
this pull request
Jan 26, 2024
…4646) * Move copy-pasted count to a single function * Load unwrangled counts from ES * Now count the right thing * Hound * Fix (some?) tests * Load tags on Index from ES * Restore ordering by name ASC second on uses * Use _cache everywhere * Hound * Linter * Update tests * Hound * Some sort of solution for seemingly noop * Linter * Now unused? * Syntax/Typo * Only store unwrangeable value * Hound * Fix Grandparent bug? * More subtle cache bursting * Review * More explicit uncovered case * Syntax confusion * Hopefully helpful comment * Review * Obsolete See #4658 * Review * Linter * Split into (almost) unitary tags in_use still doing two things As it contains a OR * Cop * Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-6638
Purpose
Fix a test that has been (for unclear reasons) failing a lot lately. Issue partially diagnosed and solution provided here at first.
Testing Instructions
The CI should stop being red so often.