Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6638 Intermittent failure in cucumber tag_wrangling, orphan_pseud, and user_delete features #4658

Merged
merged 6 commits into from
Nov 15, 2023
Merged

AO3-6638 Intermittent failure in cucumber tag_wrangling, orphan_pseud, and user_delete features #4658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e997fa
Fix grandfather flakiness
ceithir Nov 11, 2023
ca327d7
Helpful (?) comment
ceithir Nov 11, 2023
16d7380
Fix another intermittent test
ceithir Nov 11, 2023
84eace9
Alternative fix
ceithir Nov 13, 2023
69233ca
Fix more orphan tests
ceithir Nov 13, 2023
212fb00
Merge remote-tracking branch 'upstream/master' into grandparent_test
ceithir Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions features/other_a/orphan_pseud.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Feature: Orphan pseud
When I follow "Back To Pseuds"
Then I should see "orphanpseud"
And I should see "2 works"
# Delay before orphaning to make sure the cache is expired
And it is currently 1 second from now
When I follow "Orphan Works"
Then I should see "Orphan All Works by orphanpseud"
When I choose "Take my pseud off as well"
Expand All @@ -44,6 +46,8 @@ Feature: Orphan pseud
When I follow "Back To Pseuds"
Then I should see "orphanpseud"
And I should see "2 works"
# Delay before orphaning to make sure the cache is expired
And it is currently 1 second from now
When I follow "Orphan Works"
Then I should see "Orphan All Works by orphanpseud"
When I choose "Leave a copy of my pseud on"
Expand Down
2 changes: 2 additions & 0 deletions features/tags_and_wrangling/tag_wrangling.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,8 @@ Feature: Tag wrangling
When I edit the tag "Child"
And I check the 1st checkbox with id matching "MetaTag"
And I fill in "tag_meta_tag_string" with "Grandparent"
# Ensure a new cache key will be used
And it is currently 1 second from now
And I press "Save changes"
Then I should see "Tag was updated"
And I should see "Grandparent" within "#parent_MetaTag_associations_to_remove_checkboxes"
Expand Down
9 changes: 6 additions & 3 deletions features/users/user_delete.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ Scenario: Allow a user to orphan their works when deleting their account
When I try to delete my account as orphaner
Then I should see "What do you want to do with your works?"
When I choose "Change my pseud to "orphan" and attach to the orphan account"
# Delay before orphaning to make sure the cache is expired
And it is currently 1 second from now
And I press "Save"
Then I should see "You have successfully deleted your account."
And 0 emails should be delivered
Expand All @@ -66,16 +68,17 @@ Scenario: Delete a user with a collection
When I try to delete my account as moderator
Then I should see "You have 1 collection(s) under the following pseuds: moderator."
When I choose "Change my pseud to "orphan" and attach to the orphan account"
# Delay before orphaning to make sure the cache is expired
And it is currently 1 second from now
And I press "Save"
Then I should see "You have successfully deleted your account."
And 0 emails should be delivered
And I should be logged out
And a user account should not exist for "moderator"
When I go to the collections page
Then I should see "fake"
# TODO: And a caching bug is fixed...
# And I should see "orphan_account"
# And I should not see "moderator"
And I should see "orphan_account"
And I should not see "moderator"

Scenario: Delete a user who has coauthored a work
Given the following activated users exist
Expand Down
Loading