Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-6210 Load the tags in the mass wrangling bins from Elasticsearch #4646

Merged
merged 33 commits into from
Jan 26, 2024
Merged

AO3-6210 Load the tags in the mass wrangling bins from Elasticsearch #4646

merged 33 commits into from
Jan 26, 2024

Conversation

ceithir
Copy link
Contributor

@ceithir ceithir commented Oct 23, 2023 •
edited
Loading

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6210

Purpose

Load tags from ES on the Mass Wrangling page (main table + sidebar), to hopefully increase performances

@ceithir ceithir marked this pull request as draft October 23, 2023 10:20
@ceithir ceithir mentioned this pull request Oct 23, 2023
Closed
5 tasks
@ceithir ceithir marked this pull request as ready for review October 23, 2023 18:22
brianjaustin
brianjaustin reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me, but I'd like sarken to weigh in on the comment below

app/helpers/wrangling_helper.rb Outdated Show resolved Hide resolved
features/step_definitions/tag_steps.rb Outdated Show resolved Hide resolved
app/views/tag_wranglings/index.html.erb Show resolved Hide resolved
@brianjaustin brianjaustin added the Needs Reindex Contains changes that will require Elasticsearch reindexing label Oct 30, 2023
sarken
sarken reviewed Oct 30, 2023
View reviewed changes
app/models/search/tag_indexer.rb Outdated Show resolved Hide resolved
app/views/tag_wranglings/index.html.erb Show resolved Hide resolved
redsummernight
redsummernight reviewed Dec 23, 2023
View reviewed changes
app/models/fandom.rb Show resolved Hide resolved
app/models/tag.rb Show resolved Hide resolved
app/models/search/tag_query.rb Outdated Show resolved Hide resolved
app/views/tag_wranglings/index.html.erb Outdated Show resolved Hide resolved
@ceithir
Linter
7f6ab92
@ceithir
Split into (almost) unitary tags
ae11255 
in_use still doing two things
As it contains a OR
@ceithir
Cop
56756de
redsummernight
redsummernight approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@redsummernight redsummernight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Just some minor comments on the tests.

spec/models/search/tag_query_spec.rb Outdated Show resolved Hide resolved
spec/models/search/tag_query_spec.rb Show resolved Hide resolved
@brianjaustin brianjaustin merged commit 9955683 into otwcode:master Jan 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeklies weeklies weeklies left review comments

@sarken sarken sarken left review comments

@redsummernight redsummernight redsummernight approved these changes

@brianjaustin brianjaustin brianjaustin approved these changes

Assignees
No one assigned
Labels
Needs Reindex Contains changes that will require Elasticsearch reindexing Priority: High Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceithir @sarken @brianjaustin @redsummernight @weeklies