Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature DependencyDiff (Version 0 Part 2) #2046

Merged
merged 64 commits into from
Jul 18, 2022

Conversation

aidenwang9867
Copy link
Contributor

@aidenwang9867 aidenwang9867 commented Jul 13, 2022

What kind of change does this PR introduce?

This is a follow-up PR of PR #2030, introducing the main Dependency-diff API to the Scorecard repo.

Detailed changes include:

  1. Adding the function API GetDependencyDiffResults used to fetch Scorecard results for dependency changes between two code commits and return the dependency check results (with scorecard results included);
  2. Adding the function API FetchDependencyDiffData used to get dependency-diffs between two code commits;
  3. Add the raw Dependency struct used for receiving raw data from the dependency-diff source (currently we are using the GitHub Dependency Review API);
  4. Adding AsJSON support for DependencyCheckResult, making it JSON-dump-able;
  5. Adding unit tests for corresponding functions;
  6. Minor directory and naming changes.

What is the current behavior?

In version 0 part 1 (PR #2030), only the exported result structure DependencyCheckResult was introduced.

What is the new behavior (if this is a feature change)?**

Introduce subsequent functions and structures of this feature.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

This is a part of the issue #2008.

Does this PR introduce a user-facing change?

No.

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@github-actions
Copy link

Integration tests success for
[347d74d]
(https://github.com/ossf/scorecard/actions/runs/2688579976)

@github-actions
Copy link

Integration tests success for
[4e5e7a4]
(https://github.com/ossf/scorecard/actions/runs/2688580750)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 17:41 Inactive
@github-actions
Copy link

Integration tests success for
[a8f30d9]
(https://github.com/ossf/scorecard/actions/runs/2692388330)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 18:02 Inactive
@github-actions
Copy link

Integration tests success for
[08fa625]
(https://github.com/ossf/scorecard/actions/runs/2692498810)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 18:34 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) July 18, 2022 18:36
@github-actions
Copy link

Integration tests success for
[3cb16cc]
(https://github.com/ossf/scorecard/actions/runs/2692685722)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 19:15 Inactive
@github-actions
Copy link

Integration tests success for
[e2b13e0]
(https://github.com/ossf/scorecard/actions/runs/2692808575)

@laurentsimon laurentsimon merged commit 10681da into ossf:main Jul 18, 2022
@aidenwang9867 aidenwang9867 deleted the depdiff_p2 branch July 18, 2022 20:08
@aidenwang9867 aidenwang9867 restored the depdiff_p2 branch July 18, 2022 20:08
singhsaurabh pushed a commit to singhsaurabh/scorecard that referenced this pull request Jul 25, 2022
* temp

* Update dependencies.go

* Update errors.go

* Update scorecard_results.go

* Update vulnerabilities.go

* save

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp0713-1

* temp0713-2

* temp0713-3

* temp0713-4

* temp0713-4

* temp0713-5

* temp0713-6

* temp0713-7

* temp0713-8

* temp0713-9

* temp0713-10

* temp0713-11

* temp0713-12

* 1

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* temp

* save

* save

* save

* final_commit_before_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants