🐛 Bug fixing: Repo initialization in Dependencydiff #2070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenwang9867
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
need rebase? |
|
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
- Coverage 42.11% 42.01% -0.10%
==========================================
Files 92 92
Lines 7551 7556 +5
==========================================
- Hits 3180 3175 -5
- Misses 4122 4132 +10
Partials 249 249 |
|
used the wrong branch as the base |
|
Integration tests success for |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixing a bug introduced in PR #2046 where the
ghRepotype of (clients.Repo) was created wrongly by the inputrepoURIrather than the dependency repo to be checked by scorecard.What is the current behavior?
The Dependencydiff module uses the input repo to initialize the
ghRepoto run the scorecard check, resulting in all of the dependencies having the same check results and scores (of the input repo).What is the new behavior (if this is a feature change)?**
The module will correctly initialize
ghRepousing the dependency's srcRepo URI.Which issue(s) this PR fixes
Fixes #2046
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)