Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug fixing: Using the wrong URI to initialize the repo in Dependencydiff #2072

Merged
merged 7 commits into from
Jul 19, 2022
Merged

🐛 Bug fixing: Using the wrong URI to initialize the repo in Dependencydiff #2072

merged 7 commits into from
Jul 19, 2022

Conversation

aidenwang9867
Copy link
Contributor

What kind of change does this PR introduce?

Fixing a bug introduced in PR #2046 where the ghRepo type of (clients.Repo) was created wrongly by the input repoURI rather than the dependency repoURI to be checked by scorecard.

What is the current behavior?

The Dependencydiff module uses the input repo to initialize the ghRepo to run the scorecard check, resulting in all of the dependencies having the same check results and scores (of the input repo).

What is the new behavior (if this is a feature change)?**

The module will correctly initialize ghRepo using the dependency's srcRepo URI.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2046

Special notes for your reviewer

Does this PR introduce a user-facing change?

No.

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 22:48 Inactive
@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 22:49 Inactive
@codecov
Copy link

codecov bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Merging #2072 (1f8ca4f) into main (10681da) will increase coverage by 2.41%.
The diff coverage is 8.57%.

@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
+ Coverage   42.11%   44.53%   +2.41%     
==========================================
  Files          92       92              
  Lines        7551     7554       +3     
==========================================
+ Hits         3180     3364     +184     
+ Misses       4122     3934     -188     
- Partials      249      256       +7

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 22:59 Inactive
@github-actions
Copy link

Integration tests success for
[771e3a4]
(https://github.com/ossf/scorecard/actions/runs/2693966273)

@github-actions
Copy link

Integration tests success for
[779674b]
(https://github.com/ossf/scorecard/actions/runs/2693969242)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 23:16 Inactive
laurentsimon
laurentsimon approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

Integration tests success for
[82179ba]
(https://github.com/ossf/scorecard/actions/runs/2693985846)

@laurentsimon laurentsimon enabled auto-merge (squash) July 18, 2022 23:22
@github-actions
Copy link

Integration tests success for
[3d00c1a]
(https://github.com/ossf/scorecard/actions/runs/2694084783)

auto-merge was automatically disabled July 18, 2022 23:58

Head branch was pushed to by a user without write access

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 18, 2022 23:58 Inactive
@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 19, 2022 00:08 Inactive
@github-actions
Copy link

Integration tests success for
[ad88fe5]
(https://github.com/ossf/scorecard/actions/runs/2694252857)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 19, 2022 00:21 Inactive
@github-actions
Copy link

Integration tests success for
[51841f1]
(https://github.com/ossf/scorecard/actions/runs/2694289316)

@github-actions
Copy link

Integration tests success for
[1f8ca4f]
(https://github.com/ossf/scorecard/actions/runs/2694336202)

@aidenwang9867 aidenwang9867 changed the title Bug fixing: Using the wrong URI to initialize the repo in Dependencydiff 🐛 Bug fixing: Using the wrong URI to initialize the repo in Dependencydiff Jul 19, 2022
@laurentsimon laurentsimon merged commit 4bd1692 into ossf:main Jul 19, 2022
@aidenwang9867 aidenwang9867 deleted the depdiff_p2_fix_bug branch July 21, 2022 22:53
singhsaurabh pushed a commit to singhsaurabh/scorecard that referenced this pull request Jul 25, 2022
@aidenwang9867
🐛 Bug fixing: Using the wrong URI to initialize the repo in Dependenc…
aeffb40 
…ydiff (ossf#2072)

* temp

* temp

* temp

* temp

* temp

* temp

* temp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@justaugustus justaugustus Awaiting requested review from justaugustus

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidenwang9867 @laurentsimon