Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing combining characters and punctuation to font stack #858

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

claysmalley
Copy link
Member

@claysmalley claysmalley commented Apr 12, 2023

Fixes #850

Screenshot from 2023-04-11 20-32-01

Screenshot from 2023-04-11 20-32-36

Screenshot from 2023-04-11 20-33-05

Screenshot from 2023-04-11 20-28-24

Screenshot from 2023-04-11 20-29-18

Screenshot from 2023-04-11 20-56-14

@claysmalley claysmalley added bug Something isn't working internationalization labels Apr 12, 2023
"armenian": [[1328, 1423]],
"armenian": [
[1328, 1423],
[64272, 64279]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add part of Alphabetic Presentation Forms, moved from latin

@@ -108,7 +112,7 @@
],
"hebrew": [
[1424, 1535],
[64285, 64331]
[64280, 64335]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust part of Alphabetic Presentation Forms to include missing characters

@@ -120,15 +124,14 @@
],
"khmer": [[6016, 6911]],
"latin": [
[33, 767],
[33, 879],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[11360, 11391],
[42784, 43007],
[43824, 43887],
[64256, 64335],
[65280, 65519],
[64256, 64271],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce Alphabetic Presentation Forms to just the Latin part

Move fullwidth to its own category to better match CJK text

[7424, 7615],
[7680, 7935],
[8304, 8591],
[8192, 8591],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -137,6 +141,7 @@
"oriya": [[2816, 2943]],
"sinhala": [[3456, 3583]],
"space": [[32, 32]],
"symbols": [[8592, 8703]],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Arrows

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and examples check out

@claysmalley claysmalley merged commit a5ea134 into main Apr 12, 2023
@claysmalley claysmalley deleted the clay-fonts-common-chars branch April 12, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fontstack lacks punctuation characters
2 participants