Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing combining characters and punctuation to font stack #858

Merged
merged 2 commits into from
Apr 12, 2023
Merged

add missing combining characters and punctuation to font stack #858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6006a
add missing common characters to font stack
claysmalley Apr 12, 2023
676e21b
use Noto Sans Symbols for Arrows Unicode block
claysmalley Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 31 additions & 10 deletions scripts/fonts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"Noto Sans Myanmar": ["regular", "700"],
"Noto Sans Oriya": ["regular", "700"],
"Noto Sans Sinhala": ["regular", "700"],
"Noto Sans Symbols": ["regular", "700"],
"Noto Sans Tamil": ["regular", "700"],
"Noto Sans Thaana": ["regular", "700"],
"Noto Serif Tibetan": ["regular", "700"],
Expand Down Expand Up @@ -50,7 +51,10 @@
[126208, 126287],
[126464, 126719]
],
"armenian": [[1328, 1423]],
"armenian": [
[1328, 1423],
[64272, 64279]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add part of Alphabetic Presentation Forms, moved from latin

],
"bengali": [[2432, 2559]],
"bopomofo": [
[12544, 12591],
Expand Down Expand Up @@ -80,6 +84,7 @@
[11648, 11743],
[43776, 43823]
],
"fullwidth": [[65280, 65519]],
"greek": [
[880, 1023],
[7936, 8191],
Expand Down Expand Up @@ -108,7 +113,7 @@
],
"hebrew": [
[1424, 1535],
[64285, 64331]
[64280, 64335]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust part of Alphabetic Presentation Forms to include missing characters

],
"hiragana": [[12352, 12447]],
"kanbun": [[12688, 12703]],
Expand All @@ -120,15 +125,14 @@
],
"khmer": [[6016, 6911]],
"latin": [
[33, 767],
[33, 879],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Combining Diacritical Marks

[7424, 7615],
[7680, 7935],
[8304, 8591],
[8192, 8591],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add General Punctuation

[11360, 11391],
[42784, 43007],
[43824, 43887],
[64256, 64335],
[65280, 65519],
[64256, 64271],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce Alphabetic Presentation Forms to just the Latin part

Move fullwidth to its own category to better match CJK text

[67456, 67519],
[122624, 122879]
],
Expand All @@ -137,6 +141,7 @@
"oriya": [[2816, 2943]],
"sinhala": [[3456, 3583]],
"space": [[32, 32]],
"symbols": [[8592, 8703]],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Arrows

"tamil": [[2944, 3071]],
"telugu": [[3072, 3199]],
"thaana": [[1920, 1983]],
Expand All @@ -152,7 +157,7 @@
},
{
"file": "MPlusRounded1C-regular",
"ranges": ["hiragana", "kanbun", "katakana"]
"ranges": ["fullwidth", "hiragana", "kanbun", "katakana"]
},
{
"file": "NotoSansArabic-regular",
Expand Down Expand Up @@ -226,6 +231,10 @@
"file": "NotoSansSinhala-regular",
"ranges": ["sinhala"]
},
{
"file": "NotoSansSymbols-regular",
"ranges": ["symbols"]
},
{
"file": "NotoSansTamil-regular",
"ranges": ["tamil"]
Expand Down Expand Up @@ -262,7 +271,7 @@
},
{
"file": "MPlusRounded1C-700",
"ranges": ["hiragana", "kanbun", "katakana"]
"ranges": ["fullwidth", "hiragana", "kanbun", "katakana"]
},
{
"file": "NotoSansArabic-700",
Expand Down Expand Up @@ -336,6 +345,10 @@
"file": "NotoSansSinhala-700",
"ranges": ["sinhala"]
},
{
"file": "NotoSansSymbols-700",
"ranges": ["symbols"]
},
{
"file": "NotoSansTamil-700",
"ranges": ["tamil"]
Expand Down Expand Up @@ -372,7 +385,7 @@
},
{
"file": "MPlusRounded1C-regular",
"ranges": ["hiragana", "kanbun", "katakana"]
"ranges": ["fullwidth", "hiragana", "kanbun", "katakana"]
},
{
"file": "NotoSansArabic-regular",
Expand Down Expand Up @@ -446,6 +459,10 @@
"file": "NotoSansSinhala-regular",
"ranges": ["sinhala"]
},
{
"file": "NotoSansSymbols-regular",
"ranges": ["symbols"]
},
{
"file": "NotoSansTamil-regular",
"ranges": ["tamil"]
Expand Down Expand Up @@ -482,7 +499,7 @@
},
{
"file": "MPlusRounded1C-700",
"ranges": ["hiragana", "kanbun", "katakana"]
"ranges": ["fullwidth", "hiragana", "kanbun", "katakana"]
},
{
"file": "NotoSansArabic-700",
Expand Down Expand Up @@ -556,6 +573,10 @@
"file": "NotoSansSinhala-700",
"ranges": ["sinhala"]
},
{
"file": "NotoSansSymbols-700",
"ranges": ["symbols"]
},
{
"file": "NotoSansTamil-700",
"ranges": ["tamil"]
Expand Down