Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontstack lacks punctuation characters #850

Closed
1ec5 opened this issue Apr 7, 2023 · 1 comment · Fixed by #858
Closed

Fontstack lacks punctuation characters #850

1ec5 opened this issue Apr 7, 2023 · 1 comment · Fixed by #858
Assignees
Labels
bug Something isn't working fonts

Comments

@1ec5
Copy link
Member

1ec5 commented Apr 7, 2023

The fontstack is missing certain punctuation characters that commonly occur in various languages including English. These punctuation characters are omitted from the labels.

Loveland–Madeira Road (missing en dash):

Loveland–Madeira Road

Cindy’s Friendly Tavern (missing right single quote, aka apostrophe):

Cindy’s Friendly Tavern

„Die 2“ (missing German quotation marks, which have no ASCII equivalent):

„Die 2“

Storå;Højris Å, which we should be rendering as “Storå • Højris Å”:

Storå;Højris Å

The last example shows that we’ve effectively regressed #666 on linear features.

@1ec5 1ec5 added bug Something isn't working fonts labels Apr 7, 2023
@1ec5
Copy link
Member Author

1ec5 commented Apr 11, 2023

Per Slack, the Combining Diacritical Marks block is also missing. The General Punctuation, Combining Diacritical Marks, and Spacing Modifier Letters blocks are necessary for a lot of languages, even though none of them is strongly associated with a particular language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fonts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants