-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container issues in v3.7.0 #229
Comments
There no changes in container between 5.6 to 5.7 illuminate/container@5.6...5.7 Futhermore Travis also throws that the tests having php memory limits exception. You might want to increase that first since you have no problem running this locally. |
I've found solution. It's happens because If there is a need to support Laravel 5.7 as well as earlier framework versions you could use if (starts_with($this->app->version(), '5.7')) {
$this->withoutMockingConsoleOutput();
} |
Thanks @antonkomarev I was having this problem as well with my console command unit tests. |
This should be added to the README documentation. PR are welcomed |
I'm open to adding |
@crynobone I've created PR to the Laravel core: laravel/framework#25573 |
I've pushed another one solution which seems more flexible for me: laravel/framework#25574 |
PR was merged, so we will be able to use $output = $this->artisan('foo:bar')->run(); |
Laravel 5.7 changed how Artisan test can be tested. It now comes with a PendingCommand. A fix in the framework has already been merged (orchestral/testbench#229 (comment)) and will be available in a future release. This change fixes the problem in the current release.
When I'm running
$ vendor/bin/phpunit
there is fatal error:When Travis trying to run the tests there is another one error:
But when I'm running tests using PHPStorm IDE all tests are green (there are no issues).
v3.6.0 working without any issues.
Here is a link to failing PR.
The text was updated successfully, but these errors were encountered: