[5.7] Call Pending artisan command immediately

[antonkomarev]

Related to: orchestral/testbench#229

This is alternative solution for PR #25573

Sometimes there is requirement to check what has happened in application after the artisan command call. When we don't care about output, but about exact job results. We are not able to do the checks since Laravel 5.7 artisan command executing in __destruct method.

With this change we can call pending artisan command immediately.

$exitCode = $this->artisan('foo:bar')->callNow();

Before:

public function test_something()
{
    $this->withoutMockingConsoleOutput();
    $output = $this->artisan('foo:bar', [
        'id' => 1,
    ]);

    // We have no way to call artisan with mocking for this test anymore
}

After:

public function test_something()
{
    $exitCode = $this->artisan('foo:bar', [
        'id' => 1,
    ])->callNow();

    $this->artisan('baz:bar', [
        'id' => 1,
    ])->assertExitCode(0);
}

Inspired from notifications sendNow() and dispatcher dispatchNow() methods.

[antonkomarev]

Hmmm... it will call command 2 times in this way. First time on callNow method and second time on __destruct method 😢

Edit: Fixed.

[taylorotwell]

Renamed the method to run.

[antonkomarev]

Its fine. The only one question I've got: why do we need method names duplication?

framework/src/Illuminate/Foundation/Testing/PendingCommand.php

Lines 119 to 122 in d2dc1f3

	public function execute()
	{
	return $this->run();
	}

Leaving just execute() or run() will be good.