[5.7] Fix withoutMockingConsoleOutput
#25499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday #25454 was merged, but it was changed so that it mocks console output by default. You can call
withoutMockingConsoleOutput()if you don't want to mock console output.The problem with this is that
PendingCommandbinds the mockedOutputStylein the container. This means that running any artisan command (like theRefreshDatabasetrait does) will permanently mock the console output, causingwithoutMockingConsoleOutput()to not work.This PR unbinds the mocked
OutputStylefrom the container when callingwithoutMockingConsoleOutput()Also, since the others parts of the framework (such as notifications or the queue) have to be explicitly mocked, is it a better idea to not mock console output by default?