Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example #60

Closed
8 of 9 tasks
Tracked by #49
shizhMSFT opened this issue Nov 17, 2021 · 11 comments · Fixed by #182
Closed
8 of 9 tasks
Tracked by #49

Update Example #60

shizhMSFT opened this issue Nov 17, 2021 · 11 comments · Fixed by #182
Assignees
Milestone

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Nov 17, 2021

Once we have the least code working, we should update the examples so that people can try themselves.

Examples (originally from @sajayantony 's list):

  • Download Manifest
  • Download a Blob given the digest
  • Put Manifest
  • Create manifest with Annotation
  • Upload Blob
  • Upload Manifest with blob
  • Copy Artifact
  • Insecure TLS / Plain HTTP
  • HTTP Client Configuration
@shizhMSFT shizhMSFT self-assigned this Nov 17, 2021
@shizhMSFT shizhMSFT mentioned this issue Jan 12, 2022
@sajayantony
Copy link
Contributor

Add the list of items we potentially need as examples -

ORAS API Usecases

The following usecase can help define the list of examples that a new developer should be able to refer.

  1. Download Manifest
  2. Download a Blob given the digest
  3. Put Manifest
  4. Create manifest with Annotation
  5. Upload Blob
  6. Upload Manifest with blob
  7. Copy Artifact
  8. Upload manifest with reference
  9. Download reference manifest
  10. Download blob of reference manifest
  11. Copy reference
  12. Copy artifact and references

Authentication tokens

  1. Get token for operation with scopes.
  2. Validate cross mount

Example Permutations

  1. Auth required for pull/push
  2. Insecure planHttp

@shizhMSFT
Copy link
Contributor Author

Assigning this item to @qweeah.

@shizhMSFT shizhMSFT removed their assignment Mar 1, 2022
@qweeah
Copy link
Contributor

qweeah commented Mar 1, 2022

Ack

@qweeah
Copy link
Contributor

qweeah commented Mar 17, 2022

Add go-doc examples for registry target, including

  • List repositories
  • Push & pull layers and manifests
  • Tag a image
  • Resolve the tag
  • Copy image
  • List tags in a repository

@sajayantony
Copy link
Contributor

@qweeah - can you include GetManifest in the examples.

@qweeah
Copy link
Contributor

qweeah commented Apr 15, 2022

@qweeah - can you include GetManifest in the examples.

@sajayantony I think it's covered by Example_pullByTag and Example_pullByDigest

@shizhMSFT
Copy link
Contributor Author

@wangxiaoxuan273 Could you help sweeping all the scenarios and add examples for them?

@wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 Could you help sweeping all the scenarios and add examples for them?

Sure. Please assign this to me.

@Wwwsylvia
Copy link
Member

I just noticed that there is no item related to referrers in the example list.
In the following items, does artifact reference mean subject here? Or do we actually mean referrers?

  • Upload artifact reference manifest
  • Download artifact reference manifest
  • Download blob of artifact reference manifest
  • Copy reference
  • Copy artifact and references

The term reference seems to represent the artifact referencing the given manifest (which is a referrer of the given manifest) in ORAS Artifact Scenarios. I'm confused by the terms we are using here.

@wangxiaoxuan273
Copy link
Contributor

ExampleRepository_Fetch_layer is an example of Download a Blob given the digest, so this item should be checked.

@shizhMSFT
Copy link
Contributor Author

Closing as "HTTP Client Configuration" is tracked by #182 separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants