Add example for listing repositories in registry target #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
sajayantony
reviewed
Mar 18, 2022
Signed-off-by: Billy Zha <[email protected]>
|
Should we create a new file named |
shizhMSFT
reviewed
Mar 22, 2022
registry/remote/registry_test.go
Outdated
| if err != nil { | ||
| panic(err) // Handle error | ||
| } | ||
| reg.RepositoryOptions.PlainHTTP = true // Use HTTP |
There was a problem hiding this comment.
This can be simplified as reg.PlainHTTP = true.
registry/remote/registry_test.go
Outdated
Comment on lines
225
to
233
| fn := func(repos []string) error { // Setup a callback function to process returned repository list | ||
| for _, repo := range repos { | ||
| fmt.Println(repo) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| ctx := context.Background() | ||
| reg.Repositories(ctx, fn) |
There was a problem hiding this comment.
You may also want to show something like this first:
ctx := context.Background()
repos, err := registry.Repositories(ctx, reg)
if err != nil {
panic(err)
}
fmt.Println(repos)There was a problem hiding this comment.
It should be added to another function ExampleRepositories, will do that
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Done. I also added an example for the static method in registry package |
shizhMSFT
reviewed
Mar 23, 2022
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
sajayantony
reviewed
Mar 24, 2022
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
sajayantony
reviewed
Mar 24, 2022
shizhMSFT
reviewed
Mar 24, 2022
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
sajayantony
reviewed
Mar 24, 2022
Signed-off-by: Billy Zha <[email protected]>
qweeah
added a commit
to qweeah/oras-go
that referenced
this pull request
Mar 28, 2022
…#117) Signed-off-by: Billy Zha <[email protected]>
qweeah
added a commit
to qweeah/oras-go
that referenced
this pull request
Mar 30, 2022
…#117) Signed-off-by: Billy Zha <[email protected]>
qweeah
added a commit
to qweeah/oras-go
that referenced
this pull request
Apr 6, 2022
…#117) Signed-off-by: Billy Zha <[email protected]>
qweeah
added a commit
to qweeah/oras-go
that referenced
this pull request
Apr 6, 2022
…#117) Signed-off-by: Billy Zha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works for item #60 and adds an example for listing repositories.