Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples for the auth module #182

Merged
merged 10 commits into from
Jun 29, 2022
Merged

examples for the auth module #182

merged 10 commits into from
Jun 29, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Jun 16, 2022

Completes and resolves #60

Resolves #149


Examples of using the http client.

registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT mentioned this pull request Jun 23, 2022
9 tasks
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

Should we also add an "Authentication examples" entry in the README?

@shizhMSFT
Copy link
Contributor

Should we also add an "Authentication examples" entry in the README?

Yes, definitely.

registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
@wangxiaoxuan273
Copy link
Contributor Author

I'll add an extra example on refresh token in another pr.

@Wwwsylvia Wwwsylvia mentioned this pull request Jun 28, 2022
added 4 examples of the client

Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
registry/remote/auth/example_test.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 3f83f0c into oras-project:main Jun 29, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the auth-example branch June 29, 2022 06:14
@Wwwsylvia
Copy link
Member

Should we also add an "Authentication examples" entry in the README?

Related issue: #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples for the auth package Update Example
4 participants