Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for copying #121

Merged
merged 9 commits into from
Apr 1, 2022
Merged

Add example for copying #121

merged 9 commits into from
Apr 1, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Mar 22, 2022

Signed-off-by: Billy Zha [email protected]

This PR works for item #60 and adds an example for copying

sajayantony
sajayantony reviewed Mar 24, 2022
View reviewed changes
copy_test.go Outdated Show resolved Hide resolved
@qweeah qweeah marked this pull request as draft March 25, 2022 01:38
@qweeah
Copy link
Contributor Author

qweeah commented Mar 25, 2022

Convert to draft since refactoring is still WIP

@qweeah qweeah marked this pull request as ready for review March 28, 2022 04:12
@shizhMSFT
Copy link
Contributor

It is better to have Target to Target copy examples.

@shizhMSFT
Copy link
Contributor

At least, we need 4 types of examples:

  1. Remote to Remote
  2. Remote to Local
  3. Local to Remote
  4. Local to Local

You have done the first one. It is better to have the rest of three.

shizhMSFT
shizhMSFT approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 49bd44c into oras-project:main Apr 1, 2022
qweeah added a commit to qweeah/oras-go that referenced this pull request Apr 6, 2022
@qweeah
Add example for copying (oras-project#121)
0d54ec0 
Signed-off-by: Billy Zha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony sajayantony approved these changes

@Wwwsylvia Wwwsylvia Awaiting requested review from Wwwsylvia Wwwsylvia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qweeah @shizhMSFT @sajayantony