Enable override attribute on Netty dependencies #51
Conversation
This commit adds support for overriding reachability metadata when the override flag is set to true, designed to be used with oracle/graalvm-reachability-metadata#51. It is implemented by adding the required --exclude-config build arguments. Closes graalvmgh-268
This commit adds support for overriding reachability metadata when the override flag is set to true, designed to be used with oracle/graalvm-reachability-metadata#51. It is implemented by adding the required --exclude-config build arguments. Closes graalvm#268
|
I had to include empty metadata to override Netty configurations, should I add empty tests or do we have a way to exclude those for the checks? |
|
I would personally prefer if we had explicit tests for each part of Netty (especially since we are now excluding existing config, and we should check for regressions). Alternatively we could link it to the existing |
|
This commit adds support for overriding reachability metadata when the override flag is set to true, designed to be used with oracle/graalvm-reachability-metadata#51. It is implemented by adding the required --exclude-config build arguments. Closes graalvm#268
|
To add some tests, don't we need NBT 0.9.14 to be released first? Isn't it a kind of chicken and egg problem? If so we can maybe more forward with empty tests for now and add proper testing as a second step after NBT 0.9.14 and metadata repo 0.2.0 releases. |
Well, we already have a different code path for metadata location detection here. We aren't using metadata support artifact here since it isn't what we are testing - we are just using standard primitives and relying on TCK to inject the right values for us, and thus we don't rely on NBT version at all. |
|
Ok please let me know when you have done the required update and if you can add the tests. |
Signed-off-by: Lazar Mitrović <[email protected]>
* Fix FileUtilsTest * Remove unused imports in FileUtils * Add support for override flag This commit adds support for overriding reachability metadata when the override flag is set to true, designed to be used with oracle/graalvm-reachability-metadata#51. It is implemented by adding the required --exclude-config build arguments. Closes #268 * Fix NativeImagePlugin.addExcludeConfigArg and related documentation * Remove unused import * Fix functional tests
In order to exclude Netty 4.1 outdated builtin metadata. Closes oracle#9
|
Rebased on top of the commit mentioned in this comment and after various tries, I decided to skip tests for empty metadata. |
@gradinac Could you please review this PR? We should also probably update the repository version to
0.2.0-SNAPSHOTin order to express that the format has changed.