Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an override flag #9

Closed
sdeleuze opened this issue Jul 18, 2022 · 2 comments
Closed

Add an override flag #9

sdeleuze opened this issue Jul 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@sdeleuze
Copy link
Collaborator

This issue is about adding an override boolean flag to mention that the provided reachability metadata should override the one provided by the original dependency by excluding the builtin one. This is required for Netty 4.1 for example in order to avoid using the builtin build-time class initialized configuration, see netty/netty#12601 (comment) related detail about why this can't be merged in Netty 4.1 but only Netty 5.

I will also create the related https://github.com/graalvm/native-build-tools issue.
@sdeleuze sdeleuze added the enhancement New feature or request label Jul 18, 2022
@sdeleuze sdeleuze mentioned this issue Jul 18, 2022
Closed
@sdeleuze
Copy link
Collaborator Author

Likely not necessary, we can exclude builtin config via an embedded native-image.properties as of GraalVM 22.2.

@sdeleuze
Copy link
Collaborator Author

sdeleuze commented Sep 5, 2022

--exclude-config is not allowed in embedded native-image.properties so let's reopen it, we need that for Netty 4.1.

@sdeleuze sdeleuze reopened this Sep 5, 2022
sdeleuze added a commit to sdeleuze/graalvm-reachability-metadata that referenced this issue Sep 12, 2022
@sdeleuze
Add override attribute to Netty
838ae1a 
Closes gh-oracle#9
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Sep 12, 2022
@sdeleuze
Add support for override flag
99327ef 
This commit adds support for overriding reachability
metadata when the override flag is set to true, see
oracle/graalvm-reachability-metadata#9 for more
context and use cases. It is implemented by adding
required --exclude-config build arguments.

Closes graalvmgh-268
sdeleuze added a commit to sdeleuze/graalvm-reachability-metadata that referenced this issue Sep 12, 2022
@sdeleuze
Add override attribute to Netty
767aaf3 
Closes oracle#9
sdeleuze added a commit to sdeleuze/graalvm-reachability-metadata that referenced this issue Sep 12, 2022
@sdeleuze
Enable override attribute on Netty dependencies
477fa7c 
In order to exclude Netty 4.1 outdated builtin metadata.

Closes oracle#9
sdeleuze added a commit to sdeleuze/graalvm-reachability-metadata that referenced this issue Sep 12, 2022
@sdeleuze
Enable override attribute on Netty dependencies
a906b03 
In order to exclude Netty 4.1 outdated builtin metadata.

Closes oracle#9
@sdeleuze sdeleuze mentioned this issue Sep 20, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdeleuze