Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reachability metadata override flag #268

Closed
sdeleuze opened this issue Jul 18, 2022 · 2 comments
Closed

Support reachability metadata override flag #268

sdeleuze opened this issue Jul 18, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
0.9.14

Comments

@sdeleuze
Copy link
Collaborator

sdeleuze commented Jul 18, 2022 •
edited
Loading

This issue is about supporting the new reachability metadata override flag described in oracle/graalvm-reachability-metadata#9 by generating the relevant --exclude-config native image parameters (see also #185 related issue). This can be tested with Netty 4.1 artifacts once the related metadata will be contributed to the reachability metadata repository (see oracle/graalvm-reachability-metadata#10).
@sdeleuze sdeleuze added the enhancement New feature or request label Jul 18, 2022
@sdeleuze sdeleuze added this to the 0.9.14 milestone Jul 18, 2022
@sdeleuze
Copy link
Collaborator Author

Likely not necessary, we can exclude builtin config via an embedded native-image.properties as of GraalVM 22.2.

@sdeleuze sdeleuze removed this from the 0.9.14 milestone Jul 22, 2022
@sdeleuze sdeleuze added this to the 0.9.14 milestone Sep 5, 2022
@sdeleuze
Copy link
Collaborator Author

sdeleuze commented Sep 5, 2022

--exclude-config is not allowed in embedded native-image.properties so let's reopen it, we need that for Netty 4.1.

@sdeleuze sdeleuze reopened this Sep 5, 2022
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Sep 12, 2022
@sdeleuze
Add support for override flag
99327ef 
This commit adds support for overriding reachability
metadata when the override flag is set to true, see
oracle/graalvm-reachability-metadata#9 for more
context and use cases. It is implemented by adding
required --exclude-config build arguments.

Closes graalvmgh-268
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Sep 12, 2022
@sdeleuze
Add support for override flag
84b127f 
This commit adds support for overriding reachability
metadata when the override flag is set to true, designed
to be used with oracle/graalvm-reachability-metadata#51.
It is implemented by adding the required --exclude-config
build arguments.

Closes graalvmgh-268
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Sep 12, 2022
@sdeleuze
Add support for override flag
bfc3d2f 
This commit adds support for overriding reachability
metadata when the override flag is set to true, designed
to be used with oracle/graalvm-reachability-metadata#51.
It is implemented by adding the required --exclude-config
build arguments.

Closes graalvm#268
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Sep 13, 2022
@sdeleuze
Add support for override flag
795081d 
This commit adds support for overriding reachability
metadata when the override flag is set to true, designed
to be used with oracle/graalvm-reachability-metadata#51.
It is implemented by adding the required --exclude-config
build arguments.

Closes graalvm#268
@melix melix closed this as completed in cb61940 Sep 18, 2022
@sdeleuze sdeleuze mentioned this issue Sep 20, 2022
Closed
6 tasks
sdeleuze added a commit to sdeleuze/spring-aot-smoke-tests that referenced this issue Sep 22, 2022
@sdeleuze
Remove unneeded --exclude-config parameter
4821443 
Not needed anymore after NBT 0.9.14 upgrade,
see graalvm/native-build-tools#268 related issue.
sdeleuze added a commit to sdeleuze/spring-aot-smoke-tests that referenced this issue Sep 22, 2022
@sdeleuze
Remove unneeded --exclude-config parameter
6ff1c0e 
Not needed anymore after NBT 0.9.14 upgrade,
see graalvm/native-build-tools#268 related issue.
@philwebb philwebb mentioned this issue Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.14
Development

No branches or pull requests
1 participant
@sdeleuze