provide bailout messages for usages of CompilerAsserts.neverPartOfCompilation() #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtulach
pushed a commit
that referenced
this pull request
Feb 16, 2016
provide bailout messages for usages of CompilerAsserts.neverPartOfCompilation()
dougxc
pushed a commit
that referenced
this pull request
May 24, 2016
…truffle:ExpectErrorOnly to master * commit '943e11f73d3e50866c50e22cab2b992f901482f3': Using only the @ExpectError way of testing annotation processors
e1iu
pushed a commit
to e1iu/graal
that referenced
this pull request
Feb 20, 2020
This patch implements two types of match rules like C2.
1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.
E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`
lsl x0, x3, oracle#56
asr x0, x0, oracle#56
add x0, x2, x0, lsl oracle#3
After this patch, generated assembly above can be optimized to below:
add x0, x2, w3, sxtb oracle#3
The test cases in this patch can show more details about those match
rules.
TEST_IMG: ubuntu/graal-test
TEST_CMD: safe ./projects/jdk/graal-build-test.sh \
TEST_CMD: --suite substratevm \
TEST_CMD: --tags "fullbuild,test,helloworld" \
TEST_CMD: --refspec $GERRIT_REFSPEC
TEST_CMD:
TEST_CMD: safe ./projects/jdk/graal-build-test.sh \
TEST_CMD: --suite compiler \
TEST_CMD: --refspec $GERRIT_REFSPEC
Change-Id: I71b392eefd990d2ad838afc06fccebb3438e467c
Jira: ENTLLT-2455
Jira: ENTLLT-1927
e1iu
pushed a commit
to e1iu/graal
that referenced
this pull request
Feb 21, 2020
…/sub
This patch implements two types of match rules like C2.
1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.
E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`
lsl x0, x3, oracle#56
asr x0, x0, oracle#56
add x0, x2, x0, lsl oracle#3
After this patch, generated assembly above can be optimized to below:
add x0, x2, w3, sxtb oracle#3
The test cases in this patch can show more details about those match
rules.
Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
e1iu
pushed a commit
to e1iu/graal
that referenced
this pull request
Feb 21, 2020
This patch implements two types of match rules like C2.
1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.
E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`
lsl x0, x3, oracle#56
asr x0, x0, oracle#56
add x0, x2, x0, lsl oracle#3
After this patch, generated assembly above can be optimized to below:
add x0, x2, w3, sxtb oracle#3
The test cases in this patch can show more details about those match
rules.
Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
e1iu
pushed a commit
to e1iu/graal
that referenced
this pull request
Feb 21, 2020
This patch implements two types of match rules like C2.
1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.
E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`
lsl x0, x3, oracle#56
asr x0, x0, oracle#56
add x0, x2, x0, lsl oracle#3
After this patch, generated assembly above can be optimized to below:
add x0, x2, w3, sxtb oracle#3
The test cases in this patch can show more details about those match
rules.
Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
e1iu
pushed a commit
to e1iu/graal
that referenced
this pull request
Mar 9, 2020
1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.
E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`
lsl x0, x3, oracle#56
asr x0, x0, oracle#56
add x0, x2, x0, lsl oracle#3
After this patch, generated assembly above can be optimized to below:
add x0, x2, w3, sxtb oracle#3
The test cases in this patch can show more details about those match
rules.
Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a failed compilation, I missed those bailout messages. They would have sped up my debugging process. (I was not able to use e.g. TruffleCompilationExceptionsArePrinted from the binary I used).
IMHO we should even deprecate the option NOT to provide a message, but that's a different story.