Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pylint install for travis. #3

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Fix pylint install for travis. #3

merged 1 commit into from
Jan 19, 2016

Conversation

chumer
Copy link
Member

@chumer chumer commented Jan 19, 2016

No description provided.

chumer added a commit that referenced this pull request Jan 19, 2016
@chumer
Merge pull request #3 from graalvm/travis_update
43f9e27 
Fix pylint install for travis.
@chumer chumer merged commit 43f9e27 into master Jan 19, 2016
@chumer chumer deleted the travis_update branch January 19, 2016 16:09
jtulach
jtulach reviewed Jan 21, 2016
View reviewed changes
.travis.yml
@@ -1,6 +1,12 @@
language: java
python:
- "2.7"
jdk:
- oraclejdk8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this line means, but I remind you that Truffle has to build with JDK7.

jtulach pushed a commit to jtulach/truffle that referenced this pull request Feb 16, 2016
@mlvdv
Merge pull request oracle#3 from jtulach/DebuggerAsInstrument
3f070cf 
Debugger as instrument
dougxc pushed a commit that referenced this pull request Apr 15, 2016
@mlvdv
Merge pull request #3 in G/truffle from ~MICHAEL.VAN.DE.VANTER_ORACLE…
a82bd09 
….COM/truffle:fix-REPL-kill to master

Update the REPL debugger after change in handling of KillException.

* commit '34a435271d216211c708cf233a25df31abcf0565':
  REPL - tighten identification of KillException without dependency.
  REPL debugger:  fix handling of Kill reimplemented as subclass of ThreadDeath.
@XiaohongGong XiaohongGong mentioned this pull request Mar 21, 2019
Merged
XiaohongGong pushed a commit to XiaohongGong/graal that referenced this pull request Mar 25, 2019
AArch64: Compressed pointer decoding optimization when base is zero.
a44a5dc 
Currently decoding a compressed pointer with zero base will generate
the following code:
add x0, xzr, x0, lsl oracle#3

This patch will optimize it to:
lsl x0, x0, oracle#3

Here is a jmh benchmark to decode a compressed pointer:
public class UncompressPointer {
    private static final int field0 = 1000000;
    private int field1;

    static class A {
        B b;

        A(B b) {
            this.b = b;
        }
    }

    static class B {
        int field;

        B(int i) {
            this.field = i;
        }
    }

    static A[] arr;

    static {
        arr = new A[field0];
        for (int i = 0; i < field0; i++)
           arr[i] = new A(new B(i));
    }

    public static int func() {
        int result = 0;
        for (int i = 0; i < field0; i++) {
            result += arr[i].b.field;
        }
        return result;
    }

    @benchmark
    public void jmhUncompressPointer() {
        field1 = func();
    }
}
And the performance results:
                         Score      Error    Units
Without this patch     21598.534 ? 2188.242  us/op
With this patch        19322.791 ? 1219.022  us/op

Change-Id: I5af6799eb82470d5598f5991e9210f99874f458a
@adinn adinn mentioned this pull request Apr 17, 2019
Closed
@lvh lvh mentioned this pull request May 24, 2019
Closed
@armLeiJin armLeiJin mentioned this pull request Jul 17, 2019
Closed
chrisseaton referenced this pull request in Shopify/graal Dec 4, 2019
@chrisseaton
Merge pull request #3 from Shopify/coverage
2067056 
Fix NPE in coverage when a source has no path
e1iu pushed a commit to e1iu/graal that referenced this pull request Feb 20, 2020
AArch64: Merge shift pair and integral narrow into add/sub
3a03e19 
This patch implements two types of match rules like C2.

1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.

E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`

        lsl x0, x3, oracle#56
        asr x0, x0, oracle#56
        add x0, x2, x0, lsl oracle#3

After this patch, generated assembly above can be optimized to below:

        add x0, x2, w3, sxtb oracle#3

The test cases in this patch can show more details about those match
rules.

TEST_IMG: ubuntu/graal-test
TEST_CMD: safe ./projects/jdk/graal-build-test.sh       \
TEST_CMD:       --suite substratevm                     \
TEST_CMD:       --tags "fullbuild,test,helloworld"      \
TEST_CMD:       --refspec $GERRIT_REFSPEC
TEST_CMD:
TEST_CMD: safe ./projects/jdk/graal-build-test.sh       \
TEST_CMD:       --suite compiler                        \
TEST_CMD:       --refspec $GERRIT_REFSPEC

Change-Id: I71b392eefd990d2ad838afc06fccebb3438e467c
Jira: ENTLLT-2455
Jira: ENTLLT-1927
e1iu pushed a commit to e1iu/graal that referenced this pull request Feb 21, 2020
[DO-NOT-MERGE] AArch64: Merge shift pair and integral narrow into add…
4ef37ee 
…/sub

This patch implements two types of match rules like C2.

1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.

E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`

        lsl x0, x3, oracle#56
        asr x0, x0, oracle#56
        add x0, x2, x0, lsl oracle#3

After this patch, generated assembly above can be optimized to below:

        add x0, x2, w3, sxtb oracle#3

The test cases in this patch can show more details about those match
rules.

Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
e1iu pushed a commit to e1iu/graal that referenced this pull request Feb 21, 2020
AArch64: Merge shift pair and integral narrow into add/sub
ed72d8c 
This patch implements two types of match rules like C2.

1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.

E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`

        lsl x0, x3, oracle#56
        asr x0, x0, oracle#56
        add x0, x2, x0, lsl oracle#3

After this patch, generated assembly above can be optimized to below:

        add x0, x2, w3, sxtb oracle#3

The test cases in this patch can show more details about those match
rules.

Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
e1iu pushed a commit to e1iu/graal that referenced this pull request Feb 21, 2020
AArch64: Merge shift pair and integral narrow into add/sub
265043b 
This patch implements two types of match rules like C2.

1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.

E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`

        lsl x0, x3, oracle#56
        asr x0, x0, oracle#56
        add x0, x2, x0, lsl oracle#3

After this patch, generated assembly above can be optimized to below:

        add x0, x2, w3, sxtb oracle#3

The test cases in this patch can show more details about those match
rules.

Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
e1iu pushed a commit to e1iu/graal that referenced this pull request Mar 9, 2020
This patch implements two types of match rules like C2.
616f755 
1. Merge shift pair into add/sub.
2. Merge integral narrow into add/sub.

E.g. Below code is generated for `x + (((y << 56) >> 56) << 3)`

        lsl x0, x3, oracle#56
        asr x0, x0, oracle#56
        add x0, x2, x0, lsl oracle#3

After this patch, generated assembly above can be optimized to below:

        add x0, x2, w3, sxtb oracle#3

The test cases in this patch can show more details about those match
rules.

Change-Id: I82502186c8e9745dc07c349c3f66eae573006165
XiaohongGong pushed a commit to XiaohongGong/graal that referenced this pull request Apr 20, 2020
Apply trapping nullcheck to the uncompressed target for compressed po…
3203261 
…inter.

Trapping nullcheck might generate two uncompress instructions for the
same compressed oop in Graal. One is inserted by the backend when it
emits nullcheck. If the pointer is a compressed object, it should be
uncompressed before the nullcheck is emitted. And another one is
generated by the normal uncompressing operation. These two instructions
are duplicated with each other.
The generated codes on AArch64 like:

  ldr   w0, [x0,oracle#112]
  lsl   x2, x0, oracle#3      ; uncompressing (first)
  ldr   xzr, [x2]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  lsl   x0, x0, oracle#3      ; uncompressing (second)
  str   w1, [x0,oracle#12]

A simple way to avoid this is to apply the nullcheck to the uncompressed
result if it exists instead of to the compressed pointer when generating
the trapping nullcheck.
With the modification, the codes above could be optimized to:

  ldr   w0, [x0,oracle#112]
  lsl   x0, x0, oracle#3      ; uncompressing
  ldr   xzr, [x0]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  str   w1, [x0,oracle#12]

Change-Id: Iabfe47bbf984ed11c42555f84bdd0ccf2a5bdddb
XiaohongGong pushed a commit to XiaohongGong/graal that referenced this pull request Apr 23, 2020
Apply trapping nullcheck to the uncompressed target for compressed po…
4b391ad 
…inter.

Trapping nullcheck might generate two uncompress instructions for the
same compressed oop in Graal. One is inserted by the backend when it
emits nullcheck. If the pointer is a compressed object, it should be
uncompressed before the nullcheck is emitted. And another one is
generated by the normal uncompressing operation. These two instructions
are duplicated with each other.
The generated codes on AArch64 like:

  ldr   w0, [x0,oracle#112]
  lsl   x2, x0, oracle#3      ; uncompressing (first)
  ldr   xzr, [x2]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  lsl   x0, x0, oracle#3      ; uncompressing (second)
  str   w1, [x0,oracle#12]

A simple way to avoid this is to apply the nullcheck to the uncompressed
result if it exists instead of to the compressed pointer when generating
the trapping nullcheck.
With the modification, the codes above could be optimized to:

  ldr   w0, [x0,oracle#112]
  lsl   x0, x0, oracle#3      ; uncompressing
  ldr   xzr, [x0]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  str   w1, [x0,oracle#12]

Change-Id: Iabfe47bbf984ed11c42555f84bdd0ccf2a5bdddb
lazar-mitrovic added a commit to lazar-mitrovic/graal that referenced this pull request May 7, 2020
@lazar-mitrovic
Fix attempt oracle#3
dc8578c
lazar-mitrovic added a commit to lazar-mitrovic/graal that referenced this pull request May 7, 2020
@lazar-mitrovic
Fix attempt oracle#3
57a1664
lazar-mitrovic added a commit to lazar-mitrovic/graal that referenced this pull request May 8, 2020
@lazar-mitrovic
Fix attempt oracle#3
2c1f7ac
XiaohongGong pushed a commit to XiaohongGong/graal that referenced this pull request May 9, 2020
Apply trapping nullcheck to uncompressed object for compressed pointer.
e5b9f3f 
Trapping nullcheck might generate two uncompress instructions for
the same compressed oop on AArch64. One is inserted by the backend
when it emits nullcheck. If the object is a compressed pointer, it
is uncompressed before the nullcheck is emitted. And another one is
generated by the uncompression node used for memory access. These
two instructions are duplicated with each other.

The generated codes on AArch64 like:

  ldr   w0, [x0,oracle#112]
  lsl   x2, x0, oracle#3      ; uncompressing (first)
  ldr   xzr, [x2]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  lsl   x0, x0, oracle#3      ; uncompressing (second)
  str   w1, [x0,oracle#12]

A simple way to avoid this is to creat a new uncompression node for
the nullcheck, and let the value numbering remove the duplicated one
if possible. Since the address lowering of AMD64 can handle the
uncompressing computation for address, the created uncompression node
is wrapped to an address node and the nullcheck is finally applied on
the address.

With the modification, the codes above could be optimized to:

  ldr   w0, [x0,oracle#112]
  lsl   x0, x0, oracle#3      ; uncompressing
  ldr   xzr, [x0]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  str   w1, [x0,oracle#12]

Change-Id: Iabfe47bbf984ed11c42555f84bdd0ccf2a5bdddb
XiaohongGong pushed a commit to XiaohongGong/graal that referenced this pull request May 13, 2020
Apply trapping nullcheck to uncompressed object for compressed pointer.
f49b7cd 
Trapping nullcheck might generate two uncompress instructions for
the same compressed oop on AArch64. One is inserted by the backend
when it emits nullcheck. If the object is a compressed pointer, it
is uncompressed before the nullcheck is emitted. And another one is
generated by the uncompression node used for memory access. These
two instructions are duplicated with each other.

The generated codes on AArch64 like:

  ldr   w0, [x0,oracle#112]
  lsl   x2, x0, oracle#3      ; uncompressing (first)
  ldr   xzr, [x2]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  lsl   x0, x0, oracle#3      ; uncompressing (second)
  str   w1, [x0,oracle#12]

A simple way to avoid this is to creat a new uncompression node for
the nullcheck, and let the value numbering remove the duplicated one
if possible. Since the address lowering of AMD64 can handle the
uncompressing computation for address, the created uncompression node
is wrapped to an address node and the nullcheck is finally applied on
the address.

With the modification, the codes above could be optimized to:

  ldr   w0, [x0,oracle#112]
  lsl   x0, x0, oracle#3      ; uncompressing
  ldr   xzr, [x0]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  str   w1, [x0,oracle#12]

Change-Id: Iabfe47bbf984ed11c42555f84bdd0ccf2a5bdddb
This was referenced Jun 26, 2020
Merged
Closed
XiaohongGong pushed a commit to XiaohongGong/graal that referenced this pull request Nov 6, 2020
Apply trapping nullcheck to uncompressed object for compressed pointer.
68dd33d 
Trapping nullcheck might generate two uncompress instructions for
the same compressed oop on AArch64. One is inserted by the backend
when it emits nullcheck. If the object is a compressed pointer, it
is uncompressed before the nullcheck is emitted. And another one is
generated by the uncompression node used for memory access. These
two instructions are duplicated with each other.

The generated codes on AArch64 like:

  ldr   w0, [x0,oracle#112]
  lsl   x2, x0, oracle#3      ; uncompressing (first)
  ldr   xzr, [x2]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  lsl   x0, x0, oracle#3      ; uncompressing (second)
  str   w1, [x0,oracle#12]

A simple way to avoid this is to creat a new uncompression node for
the nullcheck, and let the value numbering remove the duplicated one
if possible. Since the address lowering of AMD64 can handle the
uncompressing computation for address, the created uncompression node
is wrapped to an address node and the nullcheck is finally applied on
the address.

With the modification, the codes above could be optimized to:

  ldr   w0, [x0,oracle#112]
  lsl   x0, x0, oracle#3      ; uncompressing
  ldr   xzr, [x0]       ; implicit exception: deoptimizes
  ......                ; fixed operations
  str   w1, [x0,oracle#12]
@dragosroban dragosroban mentioned this pull request Mar 10, 2021
Closed
@adinn adinn mentioned this pull request Jul 23, 2021
Closed
@adinn adinn mentioned this pull request Aug 27, 2021
Closed
@wirthi wirthi mentioned this pull request Oct 3, 2022
Open
zakkak added a commit to zakkak/mandrel that referenced this pull request Oct 10, 2024
@zakkak
Merge pull request oracle#3 from roberttoyonaga/GR-52454
e83311b 
Backport of GR-52454: Include signal exit handlers in the image build if JFR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
oracle-emp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chumer @jtulach @thomaswue