Fixed #4396, #4883 : Add CI checks to ensure Kotlin files , Layout xml files are only referencing colors from component_colors.xml

[MohitGupta121]

Explanation

Fixed #4396 : Add CI checks to ensure Layout xml files are only referencing colors from component_colors.xml

Fixed #4883 : Add CI checks to ensure Kotlin Files (Activities, Activity Presenters, Fragments, Fragment Presenters, Views, and View Presenters) are only referencing colors from component_colors.xml

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[MohitGupta121]

@BenHenning PTAL, the check is working fine for all xml files as you see in the CI check failure.
And also Kotlin files checks are failing.

[BenHenning]

This looks reasonable @MohitGupta121. Is there anything you want me to look at besides the patterns?

[MohitGupta121]

Is there anything you want me to look at besides the patterns?

I don't think anything else expect the Path_Pattern. And nothing from the issue side also as I see.

@BenHenning What do you think ?

[MohitGupta121]

@BenHenning PTAL, Combine kotlin files checks into 1 check
And not find any file whose suffix is ViewPresenter, So I keep it as it.
But we have files whose prefix is View but unable to get expression pattern for that. So can you please help in that.

[BenHenning]

Thanks @MohitGupta121. Do you have examples for views that use 'View' as a prefix that would need updating?

Also, please update the PR description to have the fixed issues as separate lines (otherwise GitHub doesn't hook them up to automation correctly).

[MohitGupta121]

@BenHenning Yes got the views whose prefix is "View" https://github.com/oppia/oppia-android/tree/develop/app/src/main/java/org/oppia/android/app/customview

[MohitGupta121]

@BenHenning PTAL,
Updated Tests for CustomViews also. Here is examples for all tests that are failing :

• Layout xml files : https://github.com/oppia/oppia-android/actions/runs/4289267205/jobs/7472132371#step:7:132

• Kotlin Files :

1. Activity .kt : https://github.com/oppia/oppia-android/actions/runs/4289352575/jobs/7472301291#step:7:128
2. Fragments .kt : https://github.com/oppia/oppia-android/actions/runs/4289352575/jobs/7472301291#step:7:129
3. ActivityPresenter .kt : https://github.com/oppia/oppia-android/actions/runs/4289267205/jobs/7472132371#step:7:131
4. FragmentPresenter .kt : https://github.com/oppia/oppia-android/actions/runs/4289267205/jobs/7472132371#step:7:107
5. View .kt : https://github.com/oppia/oppia-android/actions/runs/4289267205/jobs/7472132371#step:7:106

At present view not have ViewPresenter so not have any example as such but added Test in regex.

[oppiabot]

Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[MohitGupta121]

@BenHenning PTAL, Thanks.
I updated all the Regex Tests and now working for all kotlin as well as xml.
Please tell me if we need to change or update anything else.

[BenHenning]

Thanks @MohitGupta121! This LGTM!

[oppiabot]

Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!