Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST]: Implement CI check to make sure that all colors are used from component_colors.xml file only [DARK MODE] #5114

Closed
rt4914 opened this issue Aug 1, 2023 · 4 comments
Closed

[FEATURE REQUEST]: Implement CI check to make sure that all colors are used from component_colors.xml file only [DARK MODE] #5114

rt4914 opened this issue Aug 1, 2023 · 4 comments
Assignees
@MohitGupta121
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 1, 2023

Is your feature request related to a problem? Please describe.

This is more of a developer workflow task instead of a feature request.

We need to implement CI check for following task:
Other than thumbnails and icons in mipmap and drawable folder, all other places should reference color code from component_colors.xml file only. There should not be any direct usage of color from color_palette.xml or color_defs.xml or any other file.

Describe the solution you'd like

Implement a CI check to meet the above described criteria.

Describe alternatives you've considered

No response

Additional context

No response
@rt4914 rt4914 added enhancement End user-perceivable enhancements. triage needed labels Aug 1, 2023
@MohitGupta121
Copy link
Member

MohitGupta121 commented Aug 1, 2023 •
edited
Loading

@rt4914 this is already done by me in these PR #4882 #4960 (comment) but due to some confusion that need to change but that is now reverted in this PR #5081

Also I think this issue is duplicate of this #5075

@MohitGupta121 MohitGupta121 self-assigned this Aug 1, 2023
@MohitGupta121 MohitGupta121 added Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Aug 1, 2023
@adhiamboperes adhiamboperes mentioned this issue Aug 1, 2023
Closed
@MohitGupta121
Copy link
Member

So @rt4914 @adhiamboperes we can close this issue as you already solving this in #5081?

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 5, 2023

@MohitGupta121 Can you update the dark-mode wiki by removing the point which links to this issue.
You can remove this entire last-second point on the page.

Other than thumbnails and icons in mipmap and drawable folder, all other places should reference color code from component_colors.xml file only. There should not be any direct usage of color from color_palette.xml or color_defs.xml or any other file. (Note: there is an issue filed at [#5114](https://github.com/oppia/oppia-android/issues/5114) to do this automatically via a CI check, but until that issue is resolved, this needs to be checked manually.)

Once removed, you can close this issue too. Thanks.

@MohitGupta121
Copy link
Member

MohitGupta121 commented Aug 5, 2023 •
edited
Loading

Okay @rt4914 I'll do that.
But I have to remove the line from Note: ? Right?

@MohitGupta121 MohitGupta121 mentioned this issue Aug 5, 2023
Merged
6 tasks
seanlip pushed a commit that referenced this issue Aug 5, 2023
@MohitGupta121
Remove unwanted condition from dark-mode wiki (#5117)
5340492 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

As per suggested by @rt4914 in this issue
[comment](#5114 (comment))
we have to remove that line from wiki to close that issue.

<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rt4914 @seanlip @MohitGupta121