Fixed #4396, #4883 : Add CI checks to ensure Kotlin files , Layout xml files are only referencing colors from component_colors.xml

scripts/assets/file_content_validation_checks.textproto

@@ -339,6 +339,52 @@ file_content_checks {
   prohibited_content_regex: "name=.+(?<!_color).>@|name=.*[A-Z].*>@"
   failure_message: "All color declarations in component_color.xml and color_palette.xml should end with _color suffix following snake_case naming convention."
 }
+file_content_checks {
+  file_path_regex: "app/src/main/res/layout.*?/.+?\\.xml"
+  prohibited_content_regex: "@color/(?!component_color_).+"
+  failure_message: "Only colors from component_colors.xml may be used in layouts."
+  exempted_file_name: "app/src/main/res/layout/test_margin_bindable_adapter_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/profile_reset_pin_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/activity_input_interaction_view_test.xml"
+  exempted_file_name: "app/src/main/res/layout/profile_list_learner_id_item.xml"
+  exempted_file_name: "app/src/main/res/layout/mark_topics_completed_topic_view.xml"
+  exempted_file_name: "app/src/main/res/layout/onboarding_slide_final.xml"
+  exempted_file_name: "app/src/main/res/layout/home_test_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/coming_soon_topic_view.xml"
+  exempted_file_name: "app/src/main/res/layout/drawer_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/mark_topics_completed_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/mark_stories_completed_story_summary_view.xml"
+  exempted_file_name: "app/src/main/res/layout/mark_chapters_completed_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/walkthrough_topic_summary_view.xml"
+  exempted_file_name: "app/src/main/res/layout/general_availability_upgrade_notice_dialog_content.xml"
+  exempted_file_name: "app/src/main/res/layout/topic_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/profile_list_device_id_item.xml"
+  exempted_file_name: "app/src/main/res/layout/profile_list_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/profile_picture_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/splash_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/mark_chapters_completed_chapter_summary_view.xml"
+  exempted_file_name: "app/src/main/res/layout/hints_and_solution_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/topic_practice_subtopic.xml"
+  exempted_file_name: "app/src/main/res/layout/walkthrough_topic_list_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/cellular_data_dialog.xml"
+  exempted_file_name: "app/src/main/res/layout/concept_card_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/my_downloads_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout/add_profile_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/beta_notice_dialog_content.xml"
+  exempted_file_name: "app/src/main/res/layout/exploration_test_activity.xml"
+  exempted_file_name: "app/src/main/res/layout/multiple_choice_interaction_items.xml"
+  exempted_file_name: "app/src/main/res/layout-land/onboarding_slide_final.xml"
+  exempted_file_name: "app/src/main/res/layout-sw600dp-land/onboarding_slide_final.xml"
+  exempted_file_name: "app/src/main/res/layout-sw600dp/profile_list_fragment.xml"
+  exempted_file_name: "app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml"
+}
+file_content_checks {
+  file_path_regex: "app/src/main/java/org/oppia/android/app.?/.+(ActivityPresenter|FragmentPresenter|ViewPresenter|Activity|Fragment|View)\\.kt"
+  prohibited_content_regex: "R.color.(?!component_color_).+"
+  failure_message: "Only colors from component_colors.xml may be used in Kotlin Files (Activities, Fragments, Views and Presenters)."
+  exempted_file_name: "app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt"
+  exempted_file_name: "app/src/main/java/org/oppia/android/app/profile/AddProfileActivityPresenter.kt"
+}
 file_content_checks {
   file_path_regex: "app/src/main/res/values/color_defs.xml"
   prohibited_content_regex: "name=.+(?<=color).>#|name=.*[A-Z].*>#"

scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt

@@ -164,6 +164,11 @@ class RegexPatternValidationCheckTest {
     "Only colors from color_palette.xml may be used in component_colors.xml."
   private val doesNotReferenceColorFromColorDefs =
     "Only colors from color_defs.xml may be used in color_palette.xml."
+  private val doesNotReferenceColorFromComponentColorInLayouts =
+    "Only colors from component_colors.xml may be used in layouts."
+  private val doesNotReferenceColorFromComponentColorInKotlinFiles =
+    "Only colors from component_colors.xml may be used in Kotlin Files (Activities, Fragments," +
+      "Views and Presenters)."
   private val doesNotUseWorkManagerGetInstance =
     "Use AnalyticsStartupListener to retrieve an instance of WorkManager rather than fetching one" +
       " using getInstance (as the latter may create a WorkManager if one isn't already present, " +
@@ -2153,6 +2158,98 @@ class RegexPatternValidationCheckTest {
       )
   }
 
+  fun testFileContent_xmlLayouts_includesNonColorComponentReferences_fileContentIsNotCorrect() {
+    val prohibitedContent =
+      """
+        android:textColor="@color/component_color_shared_primary_text_color"
+        android:textColor="@color/color_defs_shared_primary_text_color"
+        android:textColor="@color/color_palette_primary_text_color"
+        android:textColor="#000000"
+        android:background="@color/component_color_shared_primary_text_color"
+        android:background="@color/color_defs_shared_primary_text_color"
+        android:background="@color/color_palette_primary_text_color"
+        android:background="#000000"
+        app:tint="@color/component_color_shared_primary_text_color"
+        app:tint="@color/color_defs_shared_primary_text_color"
+        app:tint="@color/color_palette_primary_text_color"
+        app:tint="#000000"        
+        app:strokeColor="@color/component_color_shared_primary_text_color"
+        app:strokeColor="@color/color_defs_shared_primary_text_color"
+        app:strokeColor="@color/color_palette_primary_text_color"
+        app:strokeColor="#000000"        
+        app:cardBackgroundColor="@color/component_color_shared_primary_text_color"
+        app:cardBackgroundColor="@color/color_defs_shared_primary_text_color"
+        app:cardBackgroundColor="@color/color_palette_primary_text_color"
+        app:cardBackgroundColor="#000000"        
+        android:background="@color/component_color_shared_primary_text_color"
+        android:background="@color/color_defs_shared_primary_text_color"
+        android:background="@color/color_palette_primary_text_color"
+        android:background="#000000"
+      """.trimIndent()
+    tempFolder.newFolder("testfiles", "app", "src", "main", "res", "layout")
+    val stringFilePath = "app/src/main/res/layout.*?/.+?\\.xml"
+    tempFolder.newFile("testfiles/$stringFilePath").writeText(prohibitedContent)
+
+    val exception = assertThrows(Exception::class) {
+      runScript()
+    }
+
+    // Verify that all patterns are properly detected & prohibited.
+    assertThat(exception).hasMessageThat().contains(REGEX_CHECK_FAILED_OUTPUT_INDICATOR)
+    assertThat(outContent.toString().trim())
+      .isEqualTo(
+        """
+        $stringFilePath:2: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:3: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:4: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:6: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:7: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:8: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:10: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:11: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:12: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:14: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:15: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:16: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:18: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:19: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:20: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:22: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:23: $doesNotReferenceColorFromComponentColorInLayouts
+        $stringFilePath:24: $doesNotReferenceColorFromComponentColorInLayouts
+        $wikiReferenceNote
+        """.trimIndent()
+      )
+  }
+
+  fun testFileContent_kotlinFiles_includesNonColorComponentReferences_fileContentIsNotCorrect() {
+    val prohibitedContent =
+      """
+        R.color.component_color_shared_activity_status_bar_color
+        R.color.color_def_avatar_background_1
+        R.color.color_palette_primary_color
+      """.trimIndent()
+    tempFolder.newFolder("testfiles", "app", "src", "main", "java", "org", "oppia", "android")
+    val stringFilePath = "app/src/main/java/org/oppia/android/app.?/." +
+      "+(ActivityPresenter|FragmentPresenter|ViewPresenter|Activity|Fragment|View)\\\\.kt"
+    tempFolder.newFile("testfiles/$stringFilePath").writeText(prohibitedContent)
+
+    val exception = assertThrows(Exception::class) {
+      runScript()
+    }
+
+    // Verify that all patterns are properly detected & prohibited.
+    assertThat(exception).hasMessageThat().contains(REGEX_CHECK_FAILED_OUTPUT_INDICATOR)
+    assertThat(outContent.toString().trim())
+      .isEqualTo(
+        """
+        $stringFilePath:2: $doesNotReferenceColorFromComponentColorInKotlinFiles
+        $stringFilePath:3: $doesNotReferenceColorFromComponentColorInKotlinFiles
+        $wikiReferenceNote
+        """.trimIndent()
+      )
+  }
+
   @Test
   fun testFileContent_colorPalette_referencesColorFromColorDefs_fileContentIsCorrect() {
     val prohibitedContent =