Fixes Part of #2326: Changes in Views inside Practice Tab [A11y]

[Mehul-Bisht]

Explanation

Fixes part of #2326: Changes in Views inside Practice Tab [A11y]
Fixed issue with checkbox accessibility for all layouts

Portrait Mode

Before	After

Landscape Mode

Status

Before changes

After Changes

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[Mehul-Bisht]

@rt4914 @FareesHussain please review my PR and notify about any improvements related to checkboxes

[Arjupta]

@Mehul-Bisht the topic_practice_header_view.xml does not need to be changed as the START button resides in topic_practice_footer_view.xml

[Mehul-Bisht]

@Mehul-Bisht the topic_practice_header_view.xml does not need to be changed as the START button resides in topic_practice_footer_view.xml

Yes I know, but the reason why I reduced padding at the bottom for the header was that I made changes to padding of the topic_practice_subtopic. So now the subtopic items have more padding at the top so the header doesn't need as much padding on the bottom as it had before. May I attach a screenshot to show the changes?

[Arjupta]

@Mehul-Bisht the topic_practice_header_view.xml does not need to be changed as the START button resides in topic_practice_footer_view.xml

Yes I know, but the reason why I reduced padding at the bottom for the header was that I made changes to padding of the topic_practice_subtopic. So now the subtopic items have more padding at the top so the header doesn't need as much padding on the bottom as it had before. May I attach a screenshot to show the changes?

Yes, also attach the screenshots for before the changes and of passing scans

[Mehul-Bisht]

Before changes screenshots are already shown here: #2326

After changes the scans for:

Portrait Mode:

Landscape Mode:

[Arjupta]

@Mehul-Bisht you have done a good work . Even if we have solved the issue this way, but we don't want the UI to change drastically.

Before	After

You must try keeping the topic_practice_header_view to be unchanged along with aligning the checkboxes to be start|top instead of start|bottom

[Mehul-Bisht]

Ok I will update it soon.

[Mehul-Bisht]

@Arjupta I have now made the specified changes in all practice tab layout files. Kindly review.

[Arjupta]

@Arjupta I have now made the specified changes in all practice tab layout files. Kindly review.

Thanks @Mehul-Bisht , nit changes

• Edit the title to be Fixes Part of #2326 as you have not worked on complete Issue
• Attach some Screenshots in the PR description like below

@rt4914 Rest everything LGTM.

Before	After	Scan

[Arjupta]

@rt4914 while testing this for landscape mode, I encountered another issue

I think this is because of the drop-shadow view, I tried to set it not important for accessibility but still the checks failed at this giving wrong indication about contrast issue in checkbox.

[rt4914]

@rt4914 while testing this for landscape mode, I encountered another issue

I think this is because of the drop-shadow view, I tried to set it not important for accessibility but still the checks failed at this giving wrong indication about contrast issue in checkbox.

@Arjupta File an issue mentioning how to reproduce this and we will have a look. Thanks.

[rt4914]

@Mehul-Bisht Update your PR description to
Fixes part of #2326: Changes in Views inside Practice Tab [A11y]
Otherwise the entire issue will get closed.

[rt4914]

Really nice work @Mehul-Bisht . Suggested one nit change.

[Mehul-Bisht]

@rt4914 @Arjupta I have made the changes to the PR title, description and minHeight attribute now, please review again.

[rt4914]

LGTM, thanks.

[Arjupta]

@Mehul-Bisht and @rt4914 are you facing this issue on a Tablet ?

[Mehul-Bisht]

@Arjupta I could not test it with a tablet since my device doesn't run emulators that well. I tried to select an appropriate value for the tablet layout.

[Arjupta]

@Arjupta I could not test it with a tablet since my device doesn't run emulators that well. I tried to select an appropriate value for the tablet layout.

It's okay . For future PR mention the tests you have done on your side.