Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in Views inside Practice Tab [A11y] #2326

Closed
Arjupta opened this issue Dec 26, 2020 · 13 comments · Fixed by #3226
Closed

Changes in Views inside Practice Tab [A11y] #2326

Arjupta opened this issue Dec 26, 2020 · 13 comments · Fixed by #3226
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 26, 2020 •
edited
Loading

Describe the bug

Views inside the Practice Tab are not fully compatible with some users from the Accessibility point of view.
Screenshot_2020-12-17-11-27-30-51_80a9469f53bfe75dbc6e8989be28e2f0
Issue 1 - The contrast ratio of the topic practice start button is not correct in the inactive state.
Issue 2 - The subtopic checkbox has a height of 24dp which is less than the standard one (48dp)

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and start Fraction Exploration
  3. Switch to the Practice Tab
  4. Scan the screenshots with the Accessibility Scanner
  5. You will see the tests that are not passed by that screen

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2
Screenshot_2020-12-17-11-27-02-40_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-17-11-26-53-15_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Certain Views does not have the correct contrast ratios (Inactive state) as mentioned in the screenshots. To solve this, one must find a way to make the views disabled instead of being in non-clickable state only

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner
@Arjupta Arjupta added Status: Not started Priority: Essential This work item must be completed for its milestone. labels Dec 26, 2020
@Arjupta Arjupta added this to the Beta milestone Dec 26, 2020
@Arjupta Arjupta changed the title Changes in Views inside Practice Tab (Accessibility point of View) Changes in Views inside Practice Tab [A11y] Jan 2, 2021
@Mehul-Bisht
Copy link
Contributor

I was able to fix the issue with the checkboxes, Can I be assigned for this issue?

@FareesHussain
Copy link
Contributor

@Arjupta is this ok to work on this
I think accessibility issues are blocked and the PR related are not to be merged now

@Mehul-Bisht
Copy link
Contributor

Please update the status to BLOCKED to clarify which issues are not open currently

@Mehul-Bisht
Copy link
Contributor

@Arjupta @FareesHussain should I not be working on this issue anymore then? (and also others which mention [A11y] in their title)

@FareesHussain
Copy link
Contributor

@rt4914 are accessibility issues open to work now?

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 20, 2021

@Mehul-Bisht @FareesHussain this particular issue can be solved with the given description. This is why it is not blocked on anything. @Mehul-Bisht you can comment here if you still want to work on this.

@Mehul-Bisht
Copy link
Contributor

Mehul-Bisht commented Jan 20, 2021 •
edited
Loading

Yes as I mentioned earlier, I was able to fix the issue with checkboxes for portrait mode but was waiting for the confirmation, so I did not fix the issue for other orientations yet. I'll do that now.

@Mehul-Bisht Mehul-Bisht mentioned this issue Jan 20, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Jan 21, 2021
@Mehul-Bisht
Fixes Part of #2326: Changes in Views inside Practice Tab [A11y] (#2525)
1144075 
* fixed accessibility issue with checkboxes

* reverted header file and edited subtopic item

* reverted changes for Project.xml file

* removed minHeight attribute for all layouts
@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 21, 2021 •
edited
Loading

Checklist

(Contributors can take one issue at a time)

  • Issue-1 (not assigned to anyone)
  • Issue-2 (already done)

@Arjupta Arjupta assigned Mehul-Bisht and unassigned Mehul-Bisht Feb 4, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Feb 4, 2021

@Mehul-Bisht as you are now able to run Tablet Emulators , you can test and create a new PR for this part of the issue you were assigned to #2525 (comment)

@Mehul-Bisht
Copy link
Contributor

@Mehul-Bisht as you are now able to run Tablet Emulators , you can test and create a new PR for this part of the issue you were assigned to #2525 (comment)

Does it require a separate branch to be created or I can make a PR to the same branch also?

@Arjupta
Copy link
Contributor Author

Arjupta commented Feb 4, 2021 •
edited
Loading

@Mehul-Bisht as you are now able to run Tablet Emulators , you can test and create a new PR for this part of the issue you were assigned to #2525 (comment)

Does it require a separate branch to be created or I can make a PR to the same branch also?

Make a new branch, it won't actually make a difference as your code is already merged

@Arjupta
Copy link
Contributor Author

Arjupta commented Feb 8, 2021

@Mehul-Bisht any update?

@Mehul-Bisht Mehul-Bisht mentioned this issue Mar 1, 2021
Closed
@Mehul-Bisht
Copy link
Contributor

@Mehul-Bisht any update?

@Arjupta I have made a PR for tablet layouts here: #2797
Kindly confirm with Rajat once and notify me about any required changes.

@rt4914 rt4914 self-assigned this May 23, 2021
@rt4914 rt4914 mentioned this issue May 23, 2021
Merged
8 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2326: A11y changes for Topic Practice Tab oppia/oppia-android
6 participants
@rt4914 @seanlip @BenHenning @FareesHussain @Arjupta @Mehul-Bisht