Fixes Part of #2326: Changes in Views inside Practice Tab [A11y] (#2525)

* fixed accessibility issue with checkboxes * reverted header file and edited subtopic item * reverted changes for Project.xml file * removed minHeight attribute for all layouts
oppia · Jan 21, 2021 · 1144075 · 1144075
1 parent 5393abe
commit 1144075
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 16 deletions.
diff --git a/app/src/main/res/layout-land/topic_practice_subtopic.xml b/app/src/main/res/layout-land/topic_practice_subtopic.xml
@@ -18,7 +18,6 @@
     android:layout_height="wrap_content"
     android:layout_marginStart="104dp"
     android:layout_marginEnd="96dp"
-    android:layout_marginBottom="26dp"
     app:barrierDirection="right">
 
     <androidx.constraintlayout.widget.Barrier
@@ -32,13 +31,13 @@
       android:id="@+id/subtopic_check_box"
       android:layout_width="match_parent"
       android:layout_height="wrap_content"
+      android:paddingBottom="26dp"
       android:button="@drawable/selector_checkbox"
       android:checked="@{isChecked}"
       android:drawableStart="@android:color/transparent"
       android:drawablePadding="20dp"
       android:fontFamily="sans-serif"
-      android:gravity="start"
-      android:minHeight="22dp"
+      android:gravity="start|top"
       android:text="@{viewModel.subtopic.title}"
       android:textAlignment="viewStart"
       android:textColor="@color/oppiaPrimaryText"

diff --git a/app/src/main/res/layout-sw600dp-land/topic_practice_subtopic.xml b/app/src/main/res/layout-sw600dp-land/topic_practice_subtopic.xml
@@ -15,9 +15,7 @@
 
   <FrameLayout
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
-    android:layout_marginTop="12dp"
-    android:layout_marginBottom="12dp">
+    android:layout_height="wrap_content">
 
     <androidx.constraintlayout.widget.ConstraintLayout
       android:layout_width="360dp"
@@ -42,8 +40,8 @@
         android:drawableStart="@android:color/transparent"
         android:drawablePadding="20dp"
         android:fontFamily="sans-serif"
-        android:gravity="start"
-        android:minHeight="22dp"
+        android:gravity="start|top"
+        android:paddingBottom="24dp"
         android:text="@{viewModel.subtopic.title}"
         android:textAlignment="viewStart"
         android:textColor="@color/oppiaPrimaryText"

diff --git a/app/src/main/res/layout-sw600dp-port/topic_practice_subtopic.xml b/app/src/main/res/layout-sw600dp-port/topic_practice_subtopic.xml
@@ -15,9 +15,7 @@
 
   <FrameLayout
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
-    android:layout_marginTop="12dp"
-    android:layout_marginBottom="12dp">
+    android:layout_height="wrap_content">
 
     <androidx.constraintlayout.widget.ConstraintLayout
       android:layout_width="360dp"
@@ -42,8 +40,8 @@
         android:drawableStart="@android:color/transparent"
         android:drawablePadding="20dp"
         android:fontFamily="sans-serif"
-        android:gravity="start"
-        android:minHeight="22dp"
+        android:gravity="start|top"
+        android:paddingBottom="24dp"
         android:text="@{viewModel.subtopic.title}"
         android:textAlignment="viewStart"
         android:textColor="@color/oppiaPrimaryText"

diff --git a/app/src/main/res/layout/topic_practice_subtopic.xml b/app/src/main/res/layout/topic_practice_subtopic.xml
@@ -18,7 +18,6 @@
     android:layout_height="wrap_content"
     android:layout_marginStart="40dp"
     android:layout_marginEnd="48dp"
-    android:layout_marginBottom="26dp"
     app:barrierDirection="right"
     app:constraint_referenced_ids="button_example,text_view_status">
 
@@ -33,13 +32,13 @@
       android:id="@+id/subtopic_check_box"
       android:layout_width="match_parent"
       android:layout_height="wrap_content"
+      android:paddingBottom="26dp"
       android:button="@drawable/selector_checkbox"
       android:checked="@{isChecked}"
       android:drawableStart="@android:color/transparent"
       android:drawablePadding="20dp"
       android:fontFamily="sans-serif"
-      android:gravity="start"
-      android:minHeight="22dp"
+      android:gravity="start|top"
       android:text="@{viewModel.subtopic.title}"
       android:textAlignment="viewStart"
       android:textColor="@color/oppiaPrimaryText"