Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #239: fixed audio related test cases that interact with StateFragment #241

Merged
merged 9 commits into from
Oct 22, 2019

Conversation

jamesxu0
Copy link
Contributor

@jamesxu0 jamesxu0 commented Oct 16, 2019

Explanation

Fixes #239: Fixed audio related tests cases that interact with StateFragment which was recently changed in PR #238.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is assigned to an appropriate reviewer.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesxu0

Though all the libraries are added properly, I am getting error in AudioFragmentTest:

Mainly in line 18: import kotlinx.coroutines.test.TestCoroutineDispatcher

It maybe some Android Studio issue but not sure yet, can you check this on your machine?

Screenshot 2019-10-17 at 10 41 46 PM

@jamesxu0
Copy link
Contributor Author

@rt4914 I spoke with @BenHenning earlier today about this. This test should be built with Robolectric and use the dependencies in testImplementation. For some reason, gradle tries to build this test when running other espresso tests. Ben said this won't be a problem when we switch to Bazel. I guess for now commenting out the test will work.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesxu0. I'm slightly confused about the new argument being introduced in StateFragment, but otherwise the PR LGTM!

@BenHenning BenHenning removed their assignment Oct 18, 2019
@jamesxu0 jamesxu0 assigned BenHenning and unassigned jamesxu0 Oct 18, 2019
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesxu0!

@BenHenning BenHenning assigned jamesxu0 and unassigned BenHenning Oct 22, 2019
@veena14cs veena14cs removed their assignment Oct 22, 2019
@veena14cs veena14cs self-requested a review October 22, 2019 07:05
@jamesxu0 jamesxu0 merged commit 8d8357b into develop Oct 22, 2019
@jamesxu0 jamesxu0 deleted the AudioTestFixes branch October 22, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix audio test cases in StateFragmentTest, AudioFragmentTest and CellularDataFragmentTest
4 participants