-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #239: fixed audio related test cases that interact with StateFragment #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though all the libraries are added properly, I am getting error in AudioFragmentTest:
Mainly in line 18: import kotlinx.coroutines.test.TestCoroutineDispatcher
It maybe some Android Studio issue but not sure yet, can you check this on your machine?
@rt4914 I spoke with @BenHenning earlier today about this. This test should be built with Robolectric and use the dependencies in testImplementation. For some reason, gradle tries to build this test when running other espresso tests. Ben said this won't be a problem when we switch to Bazel. I guess for now commenting out the test will work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jamesxu0. I'm slightly confused about the new argument being introduced in StateFragment
, but otherwise the PR LGTM!
app/src/sharedTest/java/org/oppia/app/player/audio/AudioFragmentTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jamesxu0!
Explanation
Fixes #239: Fixed audio related tests cases that interact with StateFragment which was recently changed in PR #238.
Checklist