Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio test cases in StateFragmentTest, AudioFragmentTest and CellularDataFragmentTest #239

Closed
rt4914 opened this issue Oct 16, 2019 · 1 comment · Fixed by #241
Closed

Fix audio test cases in StateFragmentTest, AudioFragmentTest and CellularDataFragmentTest #239

rt4914 opened this issue Oct 16, 2019 · 1 comment · Fixed by #241
Assignees
@jamesxu0
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.2 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Oct 16, 2019

@jamesxu0 @BenHenning

@veena14cs has updated the implementation of AudioFragment. Earlier, we were controlling the visibility of audio fragment inside StateFragment but practically the AudioFragment was always created.

So we have updated this implementation to creating or removing the AudioFragment only when needed.

Because of these changes test cases related to AudioFragment are failing.
@jamesxu0 can you have a look at them and update accordingly?
@rt4914 rt4914 changed the title Fix audio test cases in StateFragmentTest Fix audio test cases in StateFragmentTest, AudioFragmentTest and CellularDataFragmentTest Oct 16, 2019
@jamesxu0 jamesxu0 self-assigned this Oct 16, 2019
@BenHenning
Copy link
Member

We should try to avoid breaking tests when checking in PRs (ie I would normally expect these to have been fixed as part of the PR that broke them rather than checking them in broken). Be aware that in the future we will block PR submission on all tests passing.

@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. Status: In implementation labels Oct 16, 2019
@jamesxu0 jamesxu0 mentioned this issue Oct 16, 2019
Merged
6 tasks
jamesxu0 added a commit that referenced this issue Oct 22, 2019
@jamesxu0
Fixes #239: fixed audio related test cases that interact with StateFr…
8d8357b 
…agment (#241)

* Fixed audio related test cases

* Removed todos and imports

* fixed statefragment new instance

* updated ExplorationFragmentPresenter

* Changed topic to exploration

* added extra files

* Fixed AudioFragmentTest

* Added new line
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.2 Release Blockers (Prototype MR2)
Development

Successfully merging a pull request may close this issue.

Fixes #239: fixed audio related test cases that interact with StateFragment oppia/oppia-android
3 participants
@rt4914 @BenHenning @jamesxu0