Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #2258: Improvements in Add Profile Activity (Accessibility point of view) #2354

Closed
wants to merge 2 commits into from

Conversation

yk1ax
Copy link
Contributor

@yk1ax yk1ax commented Dec 31, 2020

Explanation

Fixes part of #2258
I have taken care of the accessibility issues other than adding contentDescription to the three editTexts. I'm still trying to figure out how to set contentDescription for the editTexts as they are binding through ProfileInputView so I'm trying to do something from ProfileInputView.kt

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Screenshot

@yk1ax
Copy link
Contributor Author

yk1ax commented Dec 31, 2020

@Arjupta can you have a look at my approach for resolving the contrast issues. Especially the change made at app/src/main/res/values/colors.xml line 79.

@rt4914
Copy link
Contributor

rt4914 commented Dec 31, 2020

@Arjupta Suggest not assigning any issues related to Accessibility to anyone and marking all issues as blocked because we need more details for these PRs. For example, the content description is correct or not and also the color change in this PR does solve the issue but does not mean that its correct.

Therefore I am closing this PR.

@yk1ax Apologies for inconvenience but this issue needs more details and cannot be solved right now. Thanks.

@rt4914 rt4914 closed this Dec 31, 2020
@yk1ax
Copy link
Contributor Author

yk1ax commented Dec 31, 2020

Okay @rt4914

@Arjupta
Copy link
Contributor

Arjupta commented Dec 31, 2020

@Arjupta Suggest not assigning any issues related to Accessibility to anyone and marking all issues as blocked because we need more details for these PRs. For example, the content description is correct or not and also the color change in this PR does solve the issue but does not mean that its correct.

Therefore I am closing this PR.

@yk1ax Apologies for inconvenience but this issue needs more details and cannot be solved right now. Thanks.

Okay @rt4914 , actually this issue was already assigned to @yk1ax before we decided to keep them blocked. I have also mentioned about this condition on the issue - link

@Arjupta Arjupta removed their assignment Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants