Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes needed in Add Profile Activity [A11y] #2258

Closed
Arjupta opened this issue Dec 14, 2020 · 4 comments · Fixed by #2778
Closed

Changes needed in Add Profile Activity [A11y] #2258

Arjupta opened this issue Dec 14, 2020 · 4 comments · Fixed by #2778
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 14, 2020

Describe the bug

Add Profile Activity is not fully compatible with some users from the Accessibility point of view.

Screenshot_2020-12-06-23-20-28-91_80a9469f53bfe75dbc6e8989be28e2f0

Issue 1 - The circular image view, edit image button does and info button do not have any content label.
Issue 2 - The Profile Input Views present for Entering

  • Name of the user
  • 3-digit Pin
  • Confirming that pin

Does not have a content label

Issue 3 - Certain Views does not have the correct contrast ratios (Inactive state) as mentioned in the screenshots. To solve this one must find a way to make the views disabled instead of being in the non-clickable state only

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and try to add a new user.
  3. Scan the screenshots with the Accessibility Scanner
  4. You will see the tests that are not passed by that screen
  5. Repeat this for other screens

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2 Issue 3
Screenshot_2020-12-06-23-19-56-73_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-06-23-20-07-56_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-06-23-22-31-88_80a9469f53bfe75dbc6e8989be28e2f0
Screenshot_2020-12-06-23-20-02-50_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-06-23-22-10-00_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-06-23-22-25-24_80a9469f53bfe75dbc6e8989be28e2f0
Screenshot_2020-12-06-23-20-11-66_80a9469f53bfe75dbc6e8989be28e2f0 (1) Screenshot_2020-12-06-23-22-16-36_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-06-23-22-38-88_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner
@Arjupta Arjupta added Status: Not started Priority: Essential This work item must be completed for its milestone. labels Dec 14, 2020
@Arjupta Arjupta added this to the Beta milestone Dec 14, 2020
@yk1ax
Copy link
Contributor

yk1ax commented Dec 24, 2020

@Arjupta I would like to work on this issue. Can I get assigned ?

@Arjupta
Copy link
Contributor Author

Arjupta commented Dec 25, 2020

@Arjupta I would like to work on this issue. Can I get assigned ?

You can work on this but your PR will merged only after our team members decide the correct labels, if we don't find your labels descriptive enough.

Assigning this to you

@yk1ax yk1ax mentioned this issue Dec 31, 2020
Closed
8 tasks
@rt4914 rt4914 changed the title Changes needed in Add Profile Activity (Accessibility point of view) Changes needed in Add Profile Activity (Accessibility point of view) [Blocked] Dec 31, 2020
@Arjupta Arjupta changed the title Changes needed in Add Profile Activity (Accessibility point of view) [Blocked] Changes needed in Add Profile Activity [A11y] [BLOCKED] Jan 2, 2021
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Jan 11, 2021
@Arjupta
Fix oppia#2258: Changes in Add Profile Activity[a11y]
b4034d2 
Fixes Issue 3 of oppia#2258, Changed the button to diabled according to the
state and TextColor as per Chantel's suggesstion
@Arjupta Arjupta mentioned this issue Jan 11, 2021
Merged
8 tasks
@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 21, 2021

Checklist

(Contributors can take one issue at a time)

  • Issue-1 (not assigned to anyone)
  • Issue-2 (not assigned to anyone)
  • Issue-3 (assigned to @Arjupta)

@rt4914 rt4914 closed this as completed in 2ed1870 Feb 3, 2021
@rt4914
Copy link
Contributor

rt4914 commented Feb 3, 2021

Opening because it was closed incorrectly because of github bug.

@rt4914 rt4914 reopened this Feb 3, 2021
@rt4914 rt4914 self-assigned this Feb 24, 2021
@rt4914 rt4914 changed the title Changes needed in Add Profile Activity [A11y] [BLOCKED] Changes needed in Add Profile Activity [A11y] Feb 24, 2021
@rt4914 rt4914 mentioned this issue Feb 24, 2021
Merged
8 tasks
rt4914 added a commit that referenced this issue Feb 25, 2021
@rt4914
Fix #2258: Update error color for A11y Scanner Contrast Ratio (#2778)
aa4bb98 
* Update error color

* Nit fix

* Nit fix

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2258: Update error color for A11y Scanner Contrast Ratio oppia/oppia-android
5 participants
@rt4914 @seanlip @BenHenning @yk1ax @Arjupta