Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #2258: Improvements in Add Profile Activity (Accessibility point of view) #2354

Closed
wants to merge 2 commits into from
+10 −3
Closed

Fix part of #2258: Improvements in Add Profile Activity (Accessibility point of view) #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e676952
accessibility improvements
yk1ax Dec 31, 2020
718628c
basic accessibility issues resolved
yk1ax Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/main/res/layout/add_profile_activity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
android:layout_width="120dp"
android:layout_height="120dp"
android:clickable="true"
android:contentDescription="@string/add_profile_profile_picture"
android:focusable="true"
android:src="@drawable/ic_default_avatar"
app:add_shadow="true"
Expand All @@ -54,6 +55,7 @@
android:id="@+id/add_profile_activity_edit_user_image_view"
android:layout_width="48dp"
android:layout_height="48dp"
android:contentDescription="@string/add_profile_edit_profile_picture"
android:paddingStart="12dp"
android:paddingTop="12dp"
android:src="@drawable/rounded_white_background_with_shadow"
Expand Down Expand Up @@ -104,6 +106,7 @@
android:layout_width="48dp"
android:layout_height="48dp"
android:layout_marginEnd="16dp"
android:contentDescription="@string/add_profile_info_button"
android:padding="12dp"
android:src="@drawable/ic_info_icon"
app:layout_constraintEnd_toEndOf="parent"
Expand Down Expand Up @@ -163,7 +166,7 @@
android:layout_height="wrap_content"
android:fontFamily="sans-serif"
android:text="@string/add_profile_allow_download_heading"
android:textColor="@{viewModel.validPin ? @color/oppiaPrimaryTextDark : @color/grey}"
android:textColor="@{viewModel.validPin ? @color/oppiaPrimaryTextDark : @color/black_54}"
android:textSize="16sp"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
Expand All @@ -174,7 +177,7 @@
android:layout_height="wrap_content"
android:fontFamily="sans-serif"
android:text="@string/add_profile_allow_download_sub"
android:textColor="@color/light_grey"
android:textColor="@color/black_54"
android:textSize="14sp"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/add_profile_activity_allow_download_heading_text_view"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/colors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<color name="audioLanguageActivityRadioButton">#00A89F</color>
<color name="submitButtonInactive">#61999999</color>
<color name="submitButtonTextInactive">#61000000</color>
<color name="submitButtonInactiveText">#61000000</color>
<color name="submitButtonInactiveText">#99000000</color>
<color name="grey">#CCCCCC</color>
<!-- INPUT LAYOUT EDITTEXT -->
<color name="editTextError">#923026</color>
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,10 @@
<string name="save">Save</string>
<!-- AddProfileActivity -->
<string name="add_profile_title">Add Profile</string>
<string name="add_profile_profile_picture">Your avatar image</string>
<string name="add_profile_edit_profile_picture">Edit your avatar image</string>
<string name="add_profile_enter_name">Enter a name for this profile.</string>
<string name="add_profile_info_button">Information about pin</string>
<string name="add_profile_input_name">Name*</string>
<string name="add_profile_input_pin">3-Digit PIN*</string>
<string name="add_profile_input_confirm_pin">Confirm 3-Digit PIN*</string>
Expand Down