Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #2003: Replacing space_128dp #2111

Merged
merged 9 commits into from
Nov 19, 2020
Merged

Fix part of #2003: Replacing space_128dp #2111

merged 9 commits into from
Nov 19, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Nov 14, 2020

Explanation

Fixes part of #2003
This PR replaces the use of space_128dp with dimensions of contextful names

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Arjupta
Fixes part of oppia#2003: Replacing space_128dp
bee1a24 
This PR replaces the use of space_128dp with dimensions of contextful names
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 14, 2020

@anandwana001 can you help me this failing test. I can't find the reason for it

org.oppia.android.domain.oppialogger.loguploader.LogUploadWorkerTest > testWorker_logException_withoutNetwork_enqueueRequest_verifySuccess FAILED expected: SUCCEEDED but was : RUNNING at org.oppia.android.domain.oppialogger.loguploader.LogUploadWorkerTest.testWorker_logException_withoutNetwork_enqueueRequest_verifySuccess(LogUploadWorkerTest.kt:161)

@Arjupta Arjupta requested review from rt4914 and anandwana001 and removed request for rt4914 November 14, 2020 09:32
@Arjupta Arjupta requested a review from rt4914 November 14, 2020 12:26
anandwana001
anandwana001 suggested changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta
Given the first look, added few thoughts, might need to finalize

@rt4914 added a few points

app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-sw600dp-port/content_item.xml Show resolved Hide resolved
app/src/main/res/layout-sw600dp-port/continue_interaction_item.xml Show resolved Hide resolved
@anandwana001 anandwana001 assigned Arjupta and unassigned anandwana001 Nov 15, 2020
@Arjupta Arjupta requested a review from anandwana001 November 15, 2020 05:34
rt4914
rt4914 approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

app/src/main/res/layout-sw600dp-port/content_item.xml Show resolved Hide resolved
app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Nov 15, 2020
@Arjupta Arjupta requested a review from rt4914 November 15, 2020 17:38
@rt4914
Copy link
Contributor

rt4914 commented Nov 16, 2020

@anandwana001 Will have to review this.

@rt4914 rt4914 removed their assignment Nov 16, 2020
@Arjupta Arjupta mentioned this pull request Nov 16, 2020
Merged
8 tasks
@anandwana001 anandwana001 removed their assignment Nov 18, 2020
@anandwana001
Copy link
Contributor

unassigning myself will take a look once all the checks pass.

@Arjupta Arjupta force-pushed the replacing-space-128dp branch from b0f368f to ad66849 Compare November 18, 2020 18:28
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 18, 2020

@anandwana001 please review the changes you suggested

anandwana001
anandwana001 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Arjupta

@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 19, 2020

@rt4914 PTAL

rt4914
rt4914 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 9d8606a into oppia:develop Nov 19, 2020
@Arjupta Arjupta deleted the replacing-space-128dp branch December 10, 2020 13:20
@Arjupta Arjupta mentioned this pull request Jan 6, 2021
Closed
@Yashsomalkar Yashsomalkar mentioned this pull request Jan 12, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

@anandwana001 anandwana001

@Arjupta Arjupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arjupta @rt4914 @anandwana001