Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #2003: Replacing space_32dp #2121

Merged
merged 6 commits into from
Nov 21, 2020
Merged

Fix part of #2003: Replacing space_32dp #2121

merged 6 commits into from
Nov 21, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Nov 16, 2020 •
edited by anandwana001
Loading

Explanation

Fixes part of #2003
This PR replaces the use of space_32dp with the dimensions having
contextful names.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Arjupta
Fix part of oppia#2003: Replacing space_32dp
fce4b83 
Fixes part of oppia#2003
This PR replaces the use of space_32dp with the dimensions having
contextful names.
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 16, 2020 •
edited
Loading

@rt4914 The branch of this PR will act as a base for all the stacked PRs which will be solving this issue. So this must be merged only when all the previous PRs

referencing this issue #2003 are merged before this one.

@rt4914
Copy link
Contributor

rt4914 commented Nov 17, 2020

@Arjupta As per our discussion you can update this PR now. Thanks for your patience.

@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 17, 2020

@Arjupta As per our discussion you can update this PR now. Thanks for your patience.

@rt4914 I will be updating this after all the PRs before this one gets merged. So that every new branch forked from this one doesn't have to be resolved

@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 20, 2020

@rt4914 I don't know why the tests didn't start in the first place. There are no conflicts present which can cause this. Can you help starting them?

@BenHenning
Copy link
Member

Closing & reopening to restart the actions checks since they recently broke.

@BenHenning BenHenning closed this Nov 20, 2020
@BenHenning BenHenning reopened this Nov 20, 2020
@Arjupta Arjupta requested a review from rt4914 November 21, 2020 06:07
@Arjupta
Copy link
Contributor Author

Arjupta commented Nov 21, 2020

@rt4914 it can be merged

rt4914
rt4914 approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 9581bff into oppia:develop Nov 21, 2020
@Arjupta Arjupta deleted the replacing-space-32dp branch December 10, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

@Arjupta Arjupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arjupta @rt4914 @BenHenning