Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformatting required in dimension file for better structure #2399

Closed
Arjupta opened this issue Jan 6, 2021 · 18 comments · Fixed by #5168
Closed

Reformatting required in dimension file for better structure #2399

Arjupta opened this issue Jan 6, 2021 · 18 comments · Fixed by #5168
Assignees
@aayushimathur6
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Jan 6, 2021

Currently the dimensions in the dimens.xml files are segregated in groups (all having same values). The file is too large so we must rearrange the dimensions to form the groups on the base of their name, so that we find all the the dimensions related to a particular category at once.

Reference
Category structure - #2111 (comment)
@Arjupta Arjupta added Status: Not started good first issue This item is good for new contributors to make their pull request. labels Jan 6, 2021
@Roshan13046
Copy link

Roshan13046 commented Jan 10, 2021 •
edited
Loading

I would like to make a PR for this issue.

Category structure - #2111 (comment)
Should I Rearrange in only 5 categories as mentioned below?

<!-- Question -->
<!-- Exploration -->
<!-- Input interaction -->
<!-- Fraction interaction -->
<!-- Drag Drop interaction -->
...
...
...

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 10, 2021

I would like to make a PR for this issue.

Category structure - #2111 (comment)
Should I Rearrange in only 5 categories as mentioned below?

<!-- Question -->
<!-- Exploration -->
<!-- Input interaction -->
<!-- Fraction interaction -->
<!-- Drag Drop interaction -->
...
...
...

Assigning it to you

@Roshan13046
Copy link

I would like to make a PR for this issue.

Category structure - #2111 (comment)
Should I Rearrange in only 5 categories as mentioned below?

<!-- Question -->
<!-- Exploration -->
<!-- Input interaction -->
<!-- Fraction interaction -->
<!-- Drag Drop interaction -->
...
...
...

Assigning it to you

Should I Rearrange in only 5 categories only?
Are there more categories?

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 10, 2021

I would like to make a PR for this issue.

Category structure - #2111 (comment)
Should I Rearrange in only 5 categories as mentioned below?

<!-- Question -->
<!-- Exploration -->
<!-- Input interaction -->
<!-- Fraction interaction -->
<!-- Drag Drop interaction -->
...
...
...

Assigning it to you

Should I Rearrange in only 5 categories only?
Are there more categories?

@Roshan13046 try to do it for these 5 categories first and then if you find some dimensions left after that , then consider to find more ways to group them. But if you are unable to do so then create a PR and ask me for a review.

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 17, 2021

@Roshan13046 any update on this Issue?

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 20, 2021

Removing the assignment as there is no further update from previous contributor

@Arjupta Arjupta changed the title Rearrange dimensions for better structure Reformatting required in dimension file for better structure Jan 24, 2021
@kartikeysaran
Copy link
Contributor

I am working on this issue

kartikeysaran added a commit to kartikeysaran/oppia-android that referenced this issue Feb 3, 2021
@kartikeysaran
Fix oppia#2399 Reformatting dimens structure
6307d04 
Fixes oppia#2399 
Dimens.xml was properly structured in the file
@kartikeysaran kartikeysaran mentioned this issue Feb 3, 2021
Closed
8 tasks
@Arjupta Arjupta mentioned this issue Feb 4, 2021
Merged
8 tasks
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. labels Sep 15, 2022
@dmdbilal
Copy link

Is this issue still open ?

@BenHenning
Copy link
Member

Can you confirm @rt4914?

@Yashsomalkar
Copy link

@MohitGupta121 I would like to work on this issue.

@MohitGupta121
Copy link
Member

MohitGupta121 commented Dec 14, 2022 •
edited
Loading

@Yashsomalkar assigned go ahead.
If you have any query feel free to ask me or in GitHub Discussion.

@Yashsomalkar Yashsomalkar mentioned this issue Jan 2, 2023
Closed
6 tasks
@Yashsomalkar
Copy link

Sorry for the delay. The file had a lot of content and was also busy with some college stuff.

@MohitGupta121
Copy link
Member

MohitGupta121 commented Jan 3, 2023 •
edited
Loading

Sorry for the delay. The file had a lot of content and was also busy with some college stuff.

Okay sure, no problem now please continue your PR.

@MohitGupta121
Copy link
Member

@Yashsomalkar are you still woking on this issue? If you blocked somewhere please feel free to ask. or we unassign you this issue if you not working on this?

@Yashsomalkar
Copy link

@Yashsomalkar are you still woking on this issue? If you blocked somewhere please feel free to ask. or we unassign you this issue if you not working on this?

I am working there is an issue i have mentioned you in PR please check that out

@MohitGupta121
Copy link
Member

@Yashsomalkar please link your PR with the issue by adding #tag issue number in PR description

@Yashsomalkar
Copy link

@Yashsomalkar please link your PR with the issue by adding #tag issue number in PR description

Yes i have did it its above over conversations. Should i tag it again ?

@MohitGupta121
Copy link
Member

No it's good.

@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed dev_team labels Mar 29, 2023
@adhiamboperes adhiamboperes mentioned this issue May 14, 2023
Open
@adhiamboperes adhiamboperes added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label Jun 20, 2023
@adhiamboperes adhiamboperes mentioned this issue Jul 31, 2023
Merged
6 tasks
@aayushimathur6 aayushimathur6 self-assigned this Sep 23, 2023
@aayushimathur6 aayushimathur6 mentioned this issue Oct 1, 2023
Merged
6 tasks
adhiamboperes added a commit that referenced this issue Oct 5, 2023
@aayushimathur6 @adhiamboperes
Fixes #2399: Reformatting required in dimension file for better struc…
3103b0c 
…ture (#5168)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  --> Fixes #2399 
This PR has restructured the dimens.xml files. The file is too large so
just rearranged the dimensions to form the groups on the base of their
name, so that we find all the the dimensions related to a particular
category at once with ease.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Adhiambo Peres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aayushimathur6 aayushimathur6

Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone