-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2008: Optimise code in profile_chooser_profile_view.xml #2065
Fixes #2008: Optimise code in profile_chooser_profile_view.xml #2065
Conversation
…ls_RuleClassifier' into develop
…ntTo_RuleClassifier' into develop
@rt4914 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peculiaruc This PR also has similar extra files.
One of the main reasons behind this can be that your personal-forked repo has some unnecessary local commit which are getting committed to each new branch.
One possible solution is to remove your local repo and your github repo to start working again.
And another solution is to revert the changes manually by looking at the github files-changed section.
In either case its the local commit which is creating this issue.
Thanks.
Thanks I will close all the repo now both local and remote to start again |
Explanation
Fixes Fix #1957: Optimise code in profile_chooser_profile_view.xml #2008: Optimized code in profile_chooser_profile_view.xml by adding style to TextViews using defined styles in the style.xml file and removed redundant attributes.
Flatten the view hierarchy into a single ConstraintLayout.
Checklist