Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2008: Optimise code in profile_chooser_profile_view.xml #2065

Closed
wants to merge 37 commits into from
Closed

Fixes #2008: Optimise code in profile_chooser_profile_view.xml #2065

wants to merge 37 commits into from

Conversation

peculiaruc
Copy link
Contributor

@peculiaruc peculiaruc commented Oct 30, 2020

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

pecpaker added 30 commits October 13, 2020 16:15
@peculiaruc
Copy link
Contributor Author

@rt4914 PTAL

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peculiaruc This PR also has similar extra files.

One of the main reasons behind this can be that your personal-forked repo has some unnecessary local commit which are getting committed to each new branch.

One possible solution is to remove your local repo and your github repo to start working again.
And another solution is to revert the changes manually by looking at the github files-changed section.

In either case its the local commit which is creating this issue.

Screenshot 2020-10-31 at 1 22 41 AM

Thanks.

@peculiaruc
Copy link
Contributor Author

Thanks I will close all the repo now both local and remote to start again

@peculiaruc peculiaruc closed this Oct 31, 2020
@peculiaruc peculiaruc deleted the profile_chooser_profile_view_xml branch October 31, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants